Rodin

rodin commented on pull request rodin/review-bot#90

2026-05-12 20:50:07 +00:00

feat(vcs): Gitea adapter with diff-position translation (Phase 2)

Self-Review: PR #90

Self-review against 0ec5093aeb5a5821004e1d4421d6b1a430633e39

Phase 1: Independent Findings

None — diff looks clean after addressing all prior findings.

Phase 2:…

rodin pushed to review-bot-issue-79 at rodin/review-bot

2026-05-12 20:49:41 +00:00

0ec5093aeb fix: address self-review findings on PR #90

rodin commented on pull request rodin/review-bot#90

2026-05-12 20:42:36 +00:00

feat(vcs): Gitea adapter with diff-position translation (Phase 2)

Self-Review: PR #90

Self-review against 8a0eed298a666dcd19c026c17106581f8edf5c68

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#89

2026-05-12 20:39:05 +00:00

fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Addressing MINOR and NIT findings

Pushed commit 45d009d addressing all code-level findings:

Fixed:

[MINOR] persona.go:185 (sonnet): Reordered empty doc check before multi-doc…

rodin pushed to review-bot-issue-87 at rodin/review-bot

2026-05-12 20:38:53 +00:00

45d009dd06 fix(review): address review feedback on persona YAML handling

rodin commented on pull request rodin/review-bot#89

2026-05-12 20:36:49 +00:00

fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Addressing MAJOR findings (allowlist violation)

All three review bots correctly identified that github.com/goccy/go-yaml is not on the approved dependency allowlist in CONVENTIONS.md.

**Reso…

rodin opened issue rodin/review-bot#91

2026-05-12 20:36:31 +00:00

Update CONVENTIONS.md allowlist: replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

rodin created pull request rodin/review-bot#90

2026-05-12 20:30:54 +00:00

feat(vcs): Gitea adapter with diff-position translation (Phase 2)

rodin created branch review-bot-issue-79 in rodin/review-bot

2026-05-12 20:30:34 +00:00

rodin pushed to review-bot-issue-79 at rodin/review-bot

2026-05-12 20:30:34 +00:00

8a0eed298a feat(vcs): Gitea adapter with diff-position translation

rodin created pull request rodin/review-bot#89

2026-05-12 20:27:42 +00:00

fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

rodin pushed to review-bot-issue-87 at rodin/review-bot

2026-05-12 20:27:35 +00:00

8991260333 fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

rodin created branch review-bot-issue-87 in rodin/review-bot

2026-05-12 20:27:35 +00:00

rodin commented on pull request rodin/review-bot#88

2026-05-12 20:17:04 +00:00

feat(vcs): complete Phase 1 — util.go, type cleanup, interface additions (fixes #84, #85, #86)

Self-Review: PR #88

Self-review against ec03dc2373b049889e3d09f29ac104fbaa6bc2b4

Phase 1: Independent Findings

None — diff looks clean.

The full PR was reviewed from scratch: `vcs/util.g…

rodin pushed to review-bot-issue-84 at rodin/review-bot

2026-05-12 20:07:47 +00:00

ec03dc2373 fix: address remaining review findings (interface assertions, DismissReview ctx, import order, filepath param, spelling)

rodin commented on pull request rodin/review-bot#88

2026-05-12 20:03:07 +00:00

feat(vcs): complete Phase 1 — util.go, type cleanup, interface additions (fixes #84, #85, #86)

Self-Review: PR #88

Self-review against 1749d95727f84d0228ca72ab9b8decf349f4b795

Phase 1: Independent Findings

**1. [MINOR] vcs/util_test.go — Import ordering violates goimports…

rodin commented on pull request rodin/review-bot#88

2026-05-12 19:56:32 +00:00

feat(vcs): complete Phase 1 — util.go, type cleanup, interface additions (fixes #84, #85, #86)

Review Findings Addressed (1749d95)

All 10 findings from 3 review bots have been addressed:

rodin pushed to review-bot-issue-84 at rodin/review-bot

2026-05-12 19:56:18 +00:00

1749d95727 fix(vcs): address review findings on PR #88

rodin commented on pull request rodin/review-bot#88

2026-05-12 19:50:06 +00:00

feat(vcs): complete Phase 1 — util.go, type cleanup, interface additions (fixes #84, #85, #86)

Self-Review: PR #88

Self-review against 7c83365fc46f872058c97b98354232c51473656c

Phase 1: Independent Findings

**1. [MINOR] vcs/util.go — GetAllFilesInPath stops on first error,…

rodin pushed to review-bot-issue-84 at rodin/review-bot

2026-05-12 19:38:32 +00:00

7c83365fc4 feat(vcs): complete Phase 1 — util.go, type cleanup, interface additions (fixes #84, #85, #86)