Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin opened issue rodin/review-bot#92 2026-05-12 21:56:45 +00:00
Harden PostReview against unbounded diff size
rodin commented on pull request rodin/review-bot#89 2026-05-12 21:52:12 +00:00
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Self-Review: PR #89

Self-review against 493349e11a0e4846bec63101d8d4cd0ec6e0a3b4

Phase 1: Independent Findings

None — diff looks clean. Both changes are minimal, targeted, and correct: 1.…

rodin pushed to review-bot-issue-87 at rodin/review-bot 2026-05-12 21:51:50 +00:00
493349e11a fix: correct comment accuracy and improve trailing-content check clarity
rodin commented on pull request rodin/review-bot#89 2026-05-12 21:47:33 +00:00
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Self-Review: PR #89

Self-review against 5cedeee9f43d052990640cc681b9814d8e05dc15

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#89 2026-05-12 21:42:40 +00:00
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Self-Review Findings Addressed

All findings from the self-review have been addressed in commit 5cedeee:

MINOR (2/2 fixed)

  1. docs/DESIGN-57-yaml-persona.md — Fixed stale "Library…
rodin pushed to review-bot-issue-87 at rodin/review-bot 2026-05-12 21:42:27 +00:00
5cedeee9f4 address self-review findings on PR #89
rodin commented on pull request rodin/review-bot#89 2026-05-12 21:36:53 +00:00
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Self-Review: PR #89

Self-review against 01b6af03a85f5c7433be3c50322b167b0ce3b7da

All tests pass locally (go test ./...).

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#89 2026-05-12 21:33:33 +00:00
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Self-Review: PR #89

Self-review against 01b6af03a85f5c7433be3c50322b167b0ce3b7da

All tests pass locally (go test ./...).

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#89 2026-05-12 21:24:23 +00:00
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Addressing review findings (review 2792)

Pushed commit 01b6af0.

rodin pushed to review-bot-issue-87 at rodin/review-bot 2026-05-12 21:24:11 +00:00
01b6af03a8 fix(review): address review 2792 feedback
rodin commented on pull request rodin/review-bot#90 2026-05-12 21:17:09 +00:00
feat(vcs): Gitea adapter with diff-position translation (Phase 2)

Self-Review: PR #90

Self-review against b2eea502d0ae10ee4a21d5f9a66348094829bfef

Phase 1: Independent Findings

Reviewing the diff as a stranger would:

  1. **GetPullRequest (adapter.go:36…
rodin commented on pull request rodin/review-bot#89 2026-05-12 21:14:26 +00:00
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Addressing review findings (reviews 2788, 2789, 2791)

Pushed commit 80091fb with code fixes.

Review 2788 (sonnet-review-bot, REQUEST_CHANGES)

rodin pushed to review-bot-issue-87 at rodin/review-bot 2026-05-12 21:14:04 +00:00
80091fb080 fix(review): address feedback from reviews 2788, 2789, 2791
rodin pushed to review-bot-issue-87 at rodin/review-bot 2026-05-12 21:07:12 +00:00
b5f17ddfc4 fix(security): prevent alias depth bypass in YAML validator
rodin commented on pull request rodin/review-bot#89 2026-05-12 21:05:52 +00:00
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Addressing MAJOR security findings (review #2774)

Pushed commit 8ebfa80 fixing the alias depth bypass identified by security-review-bot.

Problem

The global seen set in checkYAMLDepth…

rodin pushed to review-bot-issue-87 at rodin/review-bot 2026-05-12 21:05:41 +00:00
8ebfa80c14 fix(security): prevent alias depth bypass in YAML validator
rodin commented on pull request rodin/review-bot#90 2026-05-12 20:58:06 +00:00
feat(vcs): Gitea adapter with diff-position translation (Phase 2)

Addressed review findings from sonnet and gpt reviewers (0ec5093a):

Fixed:

  • position.go: Replaced O(n) maxPosition scan with O(1) lookup — max is now tracked during map construction.…
rodin pushed to review-bot-issue-79 at rodin/review-bot 2026-05-12 20:57:49 +00:00
b2eea502d0 refactor(gitea): address review feedback on PR #90
rodin pushed to review-bot-issue-87 at rodin/review-bot 2026-05-12 20:52:39 +00:00
144a36a2a7 docs: update DESIGN-57 to reflect goccy/go-yaml as the supported YAML library
rodin pushed to review-bot-issue-87 at rodin/review-bot 2026-05-12 20:52:32 +00:00
12f5f5a5e4 docs: update YAML library to github.com/goccy/go-yaml in CONVENTIONS.md