Rodin

rodin commented on pull request rodin/review-bot#93

2026-05-12 23:00:32 +00:00

feat(github): implement PRReader + FileReader client (#80)

Review Feedback Addressed (Round 2)

Addressing MINOR findings from reviews 2831 (sonnet), 2832 (gpt), 2834 (security) — all evaluated against 5b43afc6.

Fixed

rodin pushed to review-bot-issue-80 at rodin/review-bot

2026-05-12 23:00:15 +00:00

75f65fbf5d fix: address MINOR review findings on PR #93 (round 2)

rodin commented on pull request rodin/review-bot#93

2026-05-12 22:52:31 +00:00

feat(github): implement PRReader + FileReader client (#80)

Self-Review: PR #93

Self-review against 5b43afc6d43f890028049589c8889c13d911e36f

Phase 1: Independent Findings

Reviewed the diff as a stranger. All tests pass (go test ./github/...).…

rodin commented on pull request rodin/review-bot#93

2026-05-12 22:44:04 +00:00

feat(github): implement PRReader + FileReader client (#80)

Review Feedback Addressed

Fixed

rodin pushed to review-bot-issue-80 at rodin/review-bot

2026-05-12 22:43:52 +00:00

5b43afc6d4 fix: address review feedback on PR #93

rodin commented on pull request rodin/review-bot#93

2026-05-12 22:37:34 +00:00

feat(github): implement PRReader + FileReader client (#80)

Self-Review: PR #93

Self-review against d1ef1e21e547a2ed2903346b18afeb4e3970d0bb

Phase 1: Independent Findings

No new findings not already captured by prior reviews. All issues visible to…

rodin commented on pull request rodin/review-bot#89

2026-05-12 22:33:04 +00:00

fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Self-Review: PR #89

Self-review against 0b16c4143a061eb7ebd7707b3f710289438529d7

Phase 1: Independent Findings

None — diff looks clean. Changes are correct and well-implemented:

-…

rodin commented on pull request rodin/review-bot#89

2026-05-12 22:23:41 +00:00

fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Feedback Responses (Reviews 2800, 2803, 2804)

Fixed

TestYAMLEmptyFileRejection shared temp dir (NIT, comments #17061 / #17078) → Fixed in 0b16c41: moved t.TempDir() inside each…

rodin commented on pull request rodin/review-bot#89

2026-05-12 22:23:23 +00:00

fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

test reply to inline

rodin commented on pull request rodin/review-bot#89

2026-05-12 22:23:23 +00:00

fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

test

rodin commented on pull request rodin/review-bot#89

2026-05-12 22:23:19 +00:00

fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml

Fixed in 0b16c41: moved t.TempDir() inside each subtest for proper isolation.

rodin pushed to review-bot-issue-87 at rodin/review-bot

2026-05-12 22:22:33 +00:00

0b16c4143a test: use per-subtest TempDir in TestYAMLEmptyFileRejection

rodin pushed to review-bot-issue-80 at rodin/review-bot

2026-05-12 22:18:57 +00:00

d1ef1e21e5 feat(github): implement PRReader + FileReader client (#80)

rodin pushed to review-bot-issue-80 at rodin/review-bot

2026-05-12 22:18:00 +00:00

e324f034b5 feat(github): implement PRReader + FileReader client (#80)

rodin created pull request rodin/review-bot#93

2026-05-12 22:16:49 +00:00

feat(github): implement PRReader + FileReader client (#80)

rodin pushed to review-bot-issue-80 at rodin/review-bot

2026-05-12 22:16:39 +00:00

4b55e33a49 feat(github): implement PRReader + FileReader client (#80)

rodin created branch review-bot-issue-80 in rodin/review-bot

2026-05-12 22:16:39 +00:00

rodin commented on pull request rodin/review-bot#90

2026-05-12 22:02:06 +00:00

feat(vcs): Gitea adapter with diff-position translation (Phase 2)

Self-Review: PR #90

Self-review against d8270262d618a4feb2624e202c225dea0da13f6d

Phase 1: Independent Findings

None — diff looks clean.

The latest commit (d8270262) adds only two…

rodin commented on pull request rodin/review-bot#90

2026-05-12 21:57:07 +00:00

feat(vcs): Gitea adapter with diff-position translation (Phase 2)

Addressed self-review findings from b2eea502:

Fixed (d827026):

GetPullRequest error now wrapped: fmt.Errorf("get pull request: %w", err)
PostReview final error now wrapped:…

rodin pushed to review-bot-issue-79 at rodin/review-bot

2026-05-12 21:57:01 +00:00

d8270262d6 Wrap errors in GetPullRequest and PostReview for consistency