Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin commented on pull request rodin/review-bot#93 2026-05-13 00:30:39 +00:00
feat(github): implement PRReader + FileReader client (#80)

Review Feedback Addressed (Reviews #2867, #2868, #2870)

Fixed (commit 491df7c)

rodin pushed to review-bot-issue-80 at rodin/review-bot 2026-05-13 00:30:29 +00:00
491df7cb1f fix(github): address review findings from rounds 2867/2870
rodin opened issue rodin/review-bot#96 2026-05-13 00:30:10 +00:00
Add safeguards against accidental AllowInsecureHTTP use in production
rodin opened issue rodin/review-bot#95 2026-05-13 00:30:03 +00:00
Reject cross-host redirects and HTTPS→HTTP downgrades entirely
rodin commented on pull request rodin/review-bot#93 2026-05-13 00:20:17 +00:00
feat(github): implement PRReader + FileReader client (#80)

Self-Review: PR #93

Self-review against 1fcc0b738a1fa8e036951e6a6b055a5a64aeabbb

Phase 1: Independent Findings

Reviewed the diff as a stranger. The commit (1fcc0b7) is a targeted fix…

rodin pushed to review-bot-issue-80 at rodin/review-bot 2026-05-13 00:13:11 +00:00
1fcc0b738a fix(github): address MINOR/NIT findings from review #2866
rodin commented on pull request rodin/review-bot#93 2026-05-13 00:04:35 +00:00
feat(github): implement PRReader + FileReader client (#80)

Self-Review: PR #93

Self-review against fce5f2d1840652de0eb3d8bc9068f9a313b0e2a1

Phase 1: Independent Findings

Reviewed the full diff cold (1,965 lines across 8 files).

  1. **[MINOR]…
rodin commented on pull request rodin/review-bot#93 2026-05-12 23:55:49 +00:00
feat(github): implement PRReader + FileReader client (#80)

Review Feedback Addressed (gpt-review-bot REQUEST_CHANGES against af72c64b)

Commit: fce5f2d

Fixed

rodin pushed to review-bot-issue-80 at rodin/review-bot 2026-05-12 23:55:37 +00:00
fce5f2d184 fix(github): address review findings on client.go
rodin commented on pull request rodin/review-bot#93 2026-05-12 23:48:58 +00:00
feat(github): implement PRReader + FileReader client (#80)

Feedback Addressed

Fixed the two remaining findings from self-review #17415:

rodin pushed to review-bot-issue-80 at rodin/review-bot 2026-05-12 23:48:44 +00:00
af72c64b7f fix(github): correct ListContents error wrapping and move HTTPS guard before retry loop
rodin commented on pull request rodin/review-bot#93 2026-05-12 23:45:09 +00:00
feat(github): implement PRReader + FileReader client (#80)

Self-Review: PR #93

Self-review against 1bc3f206ba49bdaef28306db64a01b16642cafe0

Phase 1: Independent Findings

Reviewed the diff cold against the current HEAD.

  1. **[MINOR] ListContents…
rodin commented on pull request rodin/review-bot#93 2026-05-12 23:39:31 +00:00
feat(github): implement PRReader + FileReader client (#80)

Review Feedback Addressed (Rounds 2843-2846)

Commit: 1bc3f20

Fixed

rodin pushed to review-bot-issue-80 at rodin/review-bot 2026-05-12 23:39:07 +00:00
1bc3f206ba fix: address review findings from rounds 2843-2846
rodin opened issue rodin/review-bot#94 2026-05-12 23:38:53 +00:00
feat(github): support HTTP-date format in Retry-After header
rodin pushed to review-bot-issue-80 at rodin/review-bot 2026-05-12 23:25:38 +00:00
c10bb72117 fix: address self-review NIT findings on PR #93
rodin commented on pull request rodin/review-bot#93 2026-05-12 23:25:21 +00:00
feat(github): implement PRReader + FileReader client (#80)

Pushback: maxPages silent truncation (#17313)

Acknowledging this is an intentional design choice:

  • The maxPages = 100 cap (10,000 items) is a safety guard against runaway pagination, not…
rodin commented on pull request rodin/review-bot#93 2026-05-12 23:20:30 +00:00
feat(github): implement PRReader + FileReader client (#80)

Self-Review: PR #93

Self-review against ae91c8aef53911ad8e178fd379cd58d84a6e5689

Phase 1: Independent Findings

Reviewed the diff cold. Identified two observations (both minor/nit,…

rodin commented on pull request rodin/review-bot#93 2026-05-12 23:12:19 +00:00
feat(github): implement PRReader + FileReader client (#80)

Review Feedback Addressed (Rounds 2834-2838)

Commit: ae91c8a

Fixed

rodin pushed to review-bot-issue-80 at rodin/review-bot 2026-05-12 23:12:02 +00:00
ae91c8aef5 fix: address review findings from rounds 2834-2838