Rodin rodin

0 Followers · 0 Following

• Joined on 2026-04-23

Repositories

16

Projects Packages Public Activity Starred Repositories

rodin created pull request rodin/review-bot#88 2026-05-12 19:31:29 +00:00

feat(vcs): add GetAllFilesInPath and BuildLineToPositionMap (#84)

rodin pushed to review-bot-issue-84 at rodin/review-bot 2026-05-12 19:31:15 +00:00

90959da830 feat(vcs): add util.go with GetAllFilesInPath and BuildLineToPositionMap (#84)

rodin created branch review-bot-issue-84 in rodin/review-bot 2026-05-12 19:31:15 +00:00

rodin opened issue rodin/review-bot#87 2026-05-12 19:19:36 +00:00

PR #58: uses gopkg.in/yaml.v3 instead of goccy/go-yaml as required by #57

rodin opened issue rodin/review-bot#86 2026-05-12 19:16:41 +00:00

PR #83: vcs interfaces and PullRequest type missing fields required by issue #78

rodin opened issue rodin/review-bot#85 2026-05-12 19:16:29 +00:00

PR #83: review.ContentEntry and review.GiteaClient not deleted as required by #78

rodin opened issue rodin/review-bot#84 2026-05-12 19:16:18 +00:00

PR #83: vcs/util.go not delivered — GetAllFilesInPath and BuildLineToPositionMap missing

rodin commented on pull request rodin/review-bot#83 2026-05-12 19:11:04 +00:00

feat(vcs): extract interfaces and types from gitea/ (Phase 1)

Self-Review: PR #83

Self-review against cd6cd93bf0dede13d9d9bc97861949d605cda997

Phase 1: Independent Findings

1. **[NIT] vcs/check_test.go — build tag phase2 vs prior ignore…

rodin commented on pull request rodin/review-bot#83 2026-05-12 19:07:57 +00:00

feat(vcs): extract interfaces and types from gitea/ (Phase 1)

Findings Addressed (cd6cd93)

sonnet-review-bot (review 2703)

#16530 [MINOR] Duplicate package doc in types.go → Fixed in prior commit (c889724). types.go no longer carries a…

rodin commented on pull request rodin/review-bot#83 2026-05-12 19:07:29 +00:00

feat(vcs): extract interfaces and types from gitea/ (Phase 1)

Fixed: removed duplicate package doc from types.go in prior commit (c889724).

rodin commented on pull request rodin/review-bot#83 2026-05-12 19:07:08 +00:00

feat(vcs): extract interfaces and types from gitea/ (Phase 1)

Fixed: removed duplicate package doc from types.go in prior commit.

rodin pushed to review-bot-issue-78 at rodin/review-bot 2026-05-12 19:06:34 +00:00

cd6cd93bf0 fix(vcs): address PR #83 review findings (round 2)

rodin commented on pull request rodin/review-bot#83 2026-05-12 19:01:08 +00:00

feat(vcs): extract interfaces and types from gitea/ (Phase 1)

Self-Review: PR #83

Self-review against c889724dda61ee4e67bf4cbb47436ab8c6d4d91c

Phase 1: Independent Findings

None — diff looks clean. The vcs package defines well-documented interfaces…

rodin pushed to review-bot-issue-78 at rodin/review-bot 2026-05-12 19:00:36 +00:00

c889724dda fix(vcs): address Phase 1 review findings

rodin reopened pull request rodin/review-bot#83 2026-05-12 18:58:37 +00:00

feat(vcs): extract interfaces and types from gitea/ (Phase 1)

rodin closed pull request rodin/review-bot#83 2026-05-12 17:47:57 +00:00

feat(vcs): extract interfaces and types from gitea/ (Phase 1)

rodin commented on issue rodin/review-bot#82 2026-05-12 17:29:49 +00:00

feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Update: fetchPatterns and fetchFileContext signatures — Both helpers currently take *gitea.Client directly.

• Update fetchPatterns to take vcs.FileReader and use `vcs.GetAllFilesInP…

rodin commented on issue rodin/review-bot#78 2026-05-12 17:29:49 +00:00

feat(vcs): extract interfaces and types from gitea/ (Phase 1)

Update: vcs/util.go — GetAllFilesInPath is recursive directory traversal, not a VCS primitive. Do not add it to the vcs.Client interface. Instead, add a utility function in this…

rodin commented on issue rodin/review-bot#80 2026-05-12 17:28:06 +00:00

feat(github): PRReader + FileReader client (Phase 3)

Update from codebase audit (issue #82): Two additional methods needed in the GitHub client:

1. GetFileContentAtRef(ctx, owner, repo, path, ref string) (string, error) — same as `GetFileCont…

rodin commented on issue rodin/review-bot#79 2026-05-12 17:28:06 +00:00

feat(vcs): Gitea adapter with diff-position translation (Phase 2)

Update from codebase audit (issue #82): The Gitea adapter needs two additional pass-through methods beyond PostReview:

1. GetFileContentAtRef → pass through to `gitea.Client.GetFileContentR…