rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

PR #83: review.ContentEntry and review.GiteaClient not deleted as required by #78 #85

New Issue
Closed
opened 2026-05-12 19:16:29 +00:00 by rodin · 0 comments
rodin commented 2026-05-12 19:16:29 +00:00
Owner
Copy Link
Copy Source

What was missed

Issue #78 explicitly required that review.ContentEntry and review.GiteaClient be deleted in the same PR as vcs/types.go, with the note: "These deletions are owned by #78 and must be included in the same PR as vcs/types.go. They are not deferred — #82 depends on them already being gone."

Both types still exist in review/repo_persona.go unchanged. review.ContentEntry duplicates vcs.ContentEntry and review.GiteaClient duplicates vcs.FileReader (partially). The review/ package can safely import vcs/ without a cycle since vcs/ has no upward dependencies.

Source

  • PR: #83 — feat(vcs): extract interfaces and types from gitea/ (Phase 1)
  • Linked issue: #78 — feat(vcs): extract interfaces and types from gitea/ (Phase 1)
  • File: review/repo_persona.go lines 14–28

What needs to happen

  • Delete review.ContentEntry from review/repo_persona.go
  • Replace all usages of review.ContentEntry in review/ with vcs.ContentEntry
  • Delete review.GiteaClient and replace with vcs.FileReader in review.LoadRepoPersonas signature
  • Update review/repo_persona_test.go: mockGiteaClient.ListContents return type changes from []review.ContentEntry to []vcs.ContentEntry
  • go build ./... and go test ./... pass

References

## What was missed Issue #78 explicitly required that `review.ContentEntry` and `review.GiteaClient` be deleted in the same PR as `vcs/types.go`, with the note: "These deletions are owned by #78 and must be included in the same PR as `vcs/types.go`. They are not deferred — #82 depends on them already being gone." Both types still exist in `review/repo_persona.go` unchanged. `review.ContentEntry` duplicates `vcs.ContentEntry` and `review.GiteaClient` duplicates `vcs.FileReader` (partially). The `review/` package can safely import `vcs/` without a cycle since `vcs/` has no upward dependencies. ## Source - PR: #83 — feat(vcs): extract interfaces and types from gitea/ (Phase 1) - Linked issue: #78 — feat(vcs): extract interfaces and types from gitea/ (Phase 1) - File: `review/repo_persona.go` lines 14–28 ## What needs to happen - Delete `review.ContentEntry` from `review/repo_persona.go` - Replace all usages of `review.ContentEntry` in `review/` with `vcs.ContentEntry` - Delete `review.GiteaClient` and replace with `vcs.FileReader` in `review.LoadRepoPersonas` signature - Update `review/repo_persona_test.go`: `mockGiteaClient.ListContents` return type changes from `[]review.ContentEntry` to `[]vcs.ContentEntry` - `go build ./...` and `go test ./...` pass ## References - [PR #83](https://gitea.weiker.me/rodin/review-bot/pulls/83) - [Issue #78](https://gitea.weiker.me/rodin/review-bot/issues/78)
rodin added the bugai-review labels 2026-05-12 19:16:29 +00:00
rodin self-assigned this 2026-05-12 19:23:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label ai-review bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees rodin
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#85
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?