rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

Update CONVENTIONS.md allowlist: replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml #91

New Issue
Closed
opened 2026-05-12 20:36:31 +00:00 by rodin · 0 comments
rodin commented 2026-05-12 20:36:31 +00:00
Owner
Copy Link
Copy Source

Context

Issue #87 and PR #89 implement the switch from gopkg.in/yaml.v3 to github.com/goccy/go-yaml as originally required by #57. However, the CONVENTIONS.md approved dependency allowlist still lists only gopkg.in/yaml.v3.

Per the documented process in CONVENTIONS.md:

  1. Open a PR that ONLY updates this table
  2. Requires explicit approval from Aaron
  3. After merge, a separate PR may use the package

Action Required

Update the approved third-party packages table in CONVENTIONS.md:

  • Remove: gopkg.in/yaml.v3
  • Add: github.com/goccy/go-yaml (and subpackages ast, parser)

This unblocks PR #89 which implements the actual migration.

Acceptance Criteria

  • CONVENTIONS.md table updated with github.com/goccy/go-yaml
  • scripts/check-deps.sh passes with the new allowlist
  • Aaron approves the dependency change
## Context Issue #87 and PR #89 implement the switch from `gopkg.in/yaml.v3` to `github.com/goccy/go-yaml` as originally required by #57. However, the CONVENTIONS.md approved dependency allowlist still lists only `gopkg.in/yaml.v3`. Per the documented process in CONVENTIONS.md: 1. Open a PR that ONLY updates this table 2. Requires explicit approval from Aaron 3. After merge, a separate PR may use the package ## Action Required Update the approved third-party packages table in CONVENTIONS.md: - Remove: `gopkg.in/yaml.v3` - Add: `github.com/goccy/go-yaml` (and subpackages `ast`, `parser`) This unblocks PR #89 which implements the actual migration. ## Acceptance Criteria - [ ] CONVENTIONS.md table updated with `github.com/goccy/go-yaml` - [ ] `scripts/check-deps.sh` passes with the new allowlist - [ ] Aaron approves the dependency change
rodin self-assigned this 2026-05-13 09:53:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees rodin
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#91
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?