Rodin rodin
  • Joined on 2026-04-23
rodin merged pull request rodin/elixir-patterns#2 2026-05-02 17:18:16 +00:00
docs: add rule for when @impl functions earn their own @doc
rodin approved rodin/elixir-patterns#2 2026-05-02 17:18:15 +00:00
docs: add rule for when @impl functions earn their own @doc

Clean consolidation. Pattern 10 now owns the full rule, cross-refs are minimal, decision test is concrete and actionable. Examples are well-chosen.

rodin pushed to main at rodin/review-bot 2026-05-02 17:07:23 +00:00
d640eb6e71 Merge pull request 'fix: distinguish 404 in GetAllFilesInPath, make uploads idempotent' (#33) from fix/8-10-error-handling-idempotent-upload into main
2339999d37 fix: URL-encode asset filename, truncate error body in APIError
bfca28b2b2 fix: address review findings from PR #33
f047c994bf fix: distinguish 404 in GetAllFilesInPath, make uploads idempotent
Compare 4 commits »
rodin closed issue rodin/review-bot#10 2026-05-02 17:07:23 +00:00
Make release asset uploads idempotent
rodin closed issue rodin/review-bot#8 2026-05-02 17:07:23 +00:00
Distinguish 404 from other errors in GetAllFilesInPath
rodin deleted branch fix/8-10-error-handling-idempotent-upload from rodin/review-bot 2026-05-02 17:07:23 +00:00
rodin merged pull request rodin/review-bot#33 2026-05-02 17:07:23 +00:00
fix: distinguish 404 in GetAllFilesInPath, make uploads idempotent
rodin pushed to fix/8-10-error-handling-idempotent-upload at rodin/review-bot 2026-05-02 17:02:06 +00:00
2339999d37 fix: URL-encode asset filename, truncate error body in APIError
rodin pushed to fix/8-10-error-handling-idempotent-upload at rodin/review-bot 2026-05-02 16:58:43 +00:00
bfca28b2b2 fix: address review findings from PR #33
rodin created pull request rodin/review-bot#33 2026-05-02 16:50:58 +00:00
fix: distinguish 404 in GetAllFilesInPath, make uploads idempotent
rodin pushed to fix/8-10-error-handling-idempotent-upload at rodin/review-bot 2026-05-02 16:50:47 +00:00
f047c994bf fix: distinguish 404 in GetAllFilesInPath, make uploads idempotent
rodin created branch fix/8-10-error-handling-idempotent-upload in rodin/review-bot 2026-05-02 16:50:47 +00:00
rodin pushed to main at rodin/review-bot 2026-05-02 16:46:08 +00:00
b51a19d8b9 Merge pull request 'fix: remove worst-wins escalation logic' (#31) from fix/28-remove-escalation into main
ceefa4c2e0 ci: use separate SECURITY_REVIEW_TOKEN for security reviewer
b1f5dd4b5f fix: skip update-in-place when shared token detected
fd179b891b fix: detect shared-token misconfiguration and warn
b78d9972ac fix: remove worst-wins escalation logic (#28)
Compare 5 commits »
rodin deleted branch fix/28-remove-escalation from rodin/review-bot 2026-05-02 16:46:08 +00:00
rodin merged pull request rodin/review-bot#31 2026-05-02 16:46:06 +00:00
fix: remove worst-wins escalation logic
rodin closed issue rodin/review-bot#29 2026-05-02 16:46:06 +00:00
Escalation deadlock risk with shared tokens
rodin closed issue rodin/review-bot#28 2026-05-02 16:46:06 +00:00
Separate token per reviewer role (eliminate worst-wins)
rodin opened issue rodin/review-bot#32 2026-05-02 16:45:36 +00:00
Improve test coverage and add end-to-end integration tests in CI
rodin pushed to fix/28-remove-escalation at rodin/review-bot 2026-05-02 14:25:46 +00:00
ceefa4c2e0 ci: use separate SECURITY_REVIEW_TOKEN for security reviewer
rodin commented on pull request rodin/review-bot#31 2026-05-02 14:21:58 +00:00
fix: remove worst-wins escalation logic

Addressed both findings:

  1. Shared-token mode now skips ALL update logic — no PATCH, no supersede, just always POST fresh. This prevents clobbering a sibling's review body or state. The…