rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

Distinguish 404 from other errors in GetAllFilesInPath #8

New Issue
Closed
opened 2026-05-01 19:23:37 +00:00 by rodin · 0 comments
rodin commented 2026-05-01 19:23:37 +00:00
Owner
Copy Link
Copy Source

Problem

GetAllFilesInPath falls back to treating the path as a file on any error from ListContents. This masks auth errors or transient failures, silently returning partial results.

Fix

Inspect error type (or HTTP status code) — only fall back to file fetch on 404. Propagate other errors.

## Problem `GetAllFilesInPath` falls back to treating the path as a file on *any* error from `ListContents`. This masks auth errors or transient failures, silently returning partial results. ## Fix Inspect error type (or HTTP status code) — only fall back to file fetch on 404. Propagate other errors.
rodin closed this issue 2026-05-02 17:07:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#8
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?