rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

Escalation deadlock risk with shared tokens #29

New Issue
Closed
opened 2026-05-02 06:13:22 +00:00 by rodin · 0 comments
rodin commented 2026-05-02 06:13:22 +00:00
Owner
Copy Link
Copy Source

With shared tokens and parallel CI jobs, a deadlock can occur:

  1. sonnet → REQUEST_CHANGES, security → escalates to REQUEST_CHANGES
  2. Dev fixes, pushes
  3. sonnet wants APPROVED but sees security REQUEST_CHANGES → re-escalates
  4. security wants APPROVED but sees sonnet REQUEST_CHANGES → re-escalates

Mitigated by the stale flag (reviews from old commits are skipped), but within the same CI run with parallel jobs, the race is theoretically possible.

Best fix: separate tokens per role (see sister issue). Alternative: don't check siblings at all and let each role post its honest verdict.

With shared tokens and parallel CI jobs, a deadlock can occur: 1. sonnet → REQUEST_CHANGES, security → escalates to REQUEST_CHANGES 2. Dev fixes, pushes 3. sonnet wants APPROVED but sees security REQUEST_CHANGES → re-escalates 4. security wants APPROVED but sees sonnet REQUEST_CHANGES → re-escalates Mitigated by the `stale` flag (reviews from old commits are skipped), but within the same CI run with parallel jobs, the race is theoretically possible. Best fix: separate tokens per role (see sister issue). Alternative: don't check siblings at all and let each role post its honest verdict.
rodin closed this issue 2026-05-02 16:46:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#29
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?