rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

Separate token per reviewer role (eliminate worst-wins) #28

New Issue
Closed
opened 2026-05-02 06:13:22 +00:00 by rodin · 0 comments
rodin commented 2026-05-02 06:13:22 +00:00
Owner
Copy Link
Copy Source

Currently sonnet and security share sonnet-review-bot token, requiring the worst-wins escalation logic. If each role has its own Gitea user+token, Gitea handles multi-reviewer blocking natively:

  • sonnet-review-bot: code quality reviews
  • security-review-bot: security reviews (new token needed)
  • gpt-review-bot: GPT reviews (already separate)

This would allow removing the entire shouldEscalate function, post-posting escalation fallback, and sentinel-based sibling detection.

Blocked by: creating the security-review-bot Gitea user and token.

Currently `sonnet` and `security` share `sonnet-review-bot` token, requiring the worst-wins escalation logic. If each role has its own Gitea user+token, Gitea handles multi-reviewer blocking natively: - `sonnet-review-bot`: code quality reviews - `security-review-bot`: security reviews (new token needed) - `gpt-review-bot`: GPT reviews (already separate) This would allow removing the entire `shouldEscalate` function, post-posting escalation fallback, and sentinel-based sibling detection. Blocked by: creating the `security-review-bot` Gitea user and token.
rodin closed this issue 2026-05-02 16:46:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#28
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?