Rodin

rodin opened issue rodin/review-bot#154

2026-05-15 08:36:05 +00:00

refactor: extract shared base-args helper in main_test.go subprocess tests

rodin closed issue rodin/review-bot#145

2026-05-15 08:35:23 +00:00

bug: dev-loop merged PR #138 despite active REQUEST_CHANGES from security-review-bot

rodin commented on issue rodin/review-bot#145

2026-05-15 08:35:23 +00:00

bug: dev-loop merged PR #138 despite active REQUEST_CHANGES from security-review-bot

Addressed by issue #148 / PR #149 (pure shell dispatch redesign), merged to main.

The REQUEST_CHANGES check is now a pure shell command:

curl ... /reviews

rodin closed issue rodin/review-bot#144

2026-05-15 08:35:23 +00:00

bug: dev-loop merged PR #140 autonomously — no human review or assignment

rodin commented on issue rodin/review-bot#144

2026-05-15 08:35:23 +00:00

bug: dev-loop merged PR #140 autonomously — no human review or assignment

Addressed by issue #148 / PR #149 (pure shell dispatch redesign), merged to main.

The dev-loop dispatch was redesigned as a pure shell script (dev-loop-dispatch.sh). Model reasoning was removed…

rodin closed issue rodin/review-bot#146

2026-05-15 08:35:06 +00:00

PR #140: missing TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile tests

rodin closed issue rodin/review-bot#147

2026-05-15 08:35:06 +00:00

PR #140: cmd/review-bot coverage at 49.3% — does not meet ≥50% acceptance criterion

rodin commented on issue rodin/review-bot#147

2026-05-15 08:35:01 +00:00

PR #140: cmd/review-bot coverage at 49.3% — does not meet ≥50% acceptance criterion

Coverage is now at 54.1%+ on origin/main (the validate-docmap subcommand added in issue #141/PR #142 brought coverage from 49.3% to 54.1%). PR #152 will push it to 54.3%.

This issue is resolved…

rodin commented on issue rodin/review-bot#146

2026-05-15 08:35:01 +00:00

PR #140: missing TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile tests

Resolved by PR #152.

TestMainSubprocess_InvalidDocMapPath added to cmd/review-bot/main_test.go (tests path traversal via validate-docmap subcommand)
`TestMainSubprocess_InvalidDocMapFile…

rodin commented on pull request rodin/review-bot#151

2026-05-15 08:34:59 +00:00

test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile

Fix Plan against 40a16b75e061528467888ad19080fa8689004e20:

Findings Summary

All findings are NIT-level. All three bots approved.

rodin created pull request rodin/review-bot#153

2026-05-15 08:34:49 +00:00

feat(#143): fetch doc-map config from trusted VCS ref

rodin pushed to issue-143 at rodin/review-bot

2026-05-15 08:34:32 +00:00

a4f04897b6 feat(#143): fetch doc-map config from trusted VCS ref

rodin created branch issue-143 in rodin/review-bot

2026-05-15 08:34:32 +00:00

rodin commented on pull request rodin/review-bot#151

2026-05-15 08:33:29 +00:00

test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile

Self-Review: PR #151

Self-review against 40a16b75e061528467888ad19080fa8689004e20

Phase 1: Independent Findings

None — diff looks clean. The production change is a small, focused…

rodin created pull request rodin/review-bot#152

2026-05-15 08:30:03 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

rodin created pull request rodin/review-bot#151

2026-05-15 08:29:53 +00:00

test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile

rodin pushed to issue-150 at rodin/review-bot

2026-05-15 08:29:45 +00:00

aee0927cfb fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

rodin created branch issue-150 in rodin/review-bot

2026-05-15 08:29:45 +00:00

rodin pushed to issue-146 at rodin/review-bot

2026-05-15 08:29:44 +00:00

40a16b75e0 test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile

rodin created branch issue-146 in rodin/review-bot

2026-05-15 08:29:44 +00:00