Rodin

rodin commented on pull request rodin/review-bot#156

2026-05-15 09:23:37 +00:00

feat(#141): validate-docmap subcommand

Multi-Model AI Review — Config A (grok-3 investigator · grok-4.3 judge)

Verdict: ✅ APPROVE

Security Analysis

The validate-docmap subcommand has solid defense-in-depth for…

rodin pushed to main at rodin/review-bot

2026-05-15 09:16:16 +00:00

823265659a chore: dev-loop run 2026-05-15 09:15 UTC — all branches passing, ready for review

rodin commented on pull request rodin/review-bot#151

2026-05-15 09:14:16 +00:00

test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile

Self-Review: PR #151

Self-review against 9b64c605f878eff32e29cc108db360fd64066059

Phase 1: Independent Findings

No issues found. The diff is clean and well-scoped:

**Production…

rodin pushed to main at rodin/review-bot

2026-05-15 09:10:35 +00:00

9be46dfbda chore: dev-loop summary — issue-130 cleanup complete, main current

rodin pushed to main at rodin/review-bot

2026-05-15 09:10:16 +00:00

d946db830c chore: dev-loop status check (2026-05-15 09:04 UTC)

f7008ab86b refactor(#130): move IsBlockedIP to internal/netutil to remove gitea import in validateurl.go

1e50a22caa refactor(#130): rename vcsReviewComment.NewPosition to NewLine with clearer semantics

3387456b93 docs(#130): fix README CLI example and env var table for VCS-agnostic usage

3e33e3d3a0 fix(#130): pass VCS_TYPE env var from action.yml Run review step

Compare 5 commits »

rodin created pull request rodin/review-bot#156

2026-05-15 09:04:39 +00:00

feat(#141): validate-docmap subcommand

rodin pushed to main at rodin/review-bot

2026-05-15 09:00:20 +00:00

3433446c19 chore: dev-loop status update — issue-130 fixes pushed, rebase conflict detected

rodin pushed to review-bot-issue-130-work at rodin/review-bot

2026-05-15 08:59:29 +00:00

24d4dcb751 chore(#130): mark self-review findings as addressed in TODO.md

f0ba8fe004 refactor(#130): move IsBlockedIP to internal/netutil to remove gitea import in validateurl.go

c5261b9b7f refactor(#130): rename vcsReviewComment.NewPosition to NewLine with clearer semantics

9a1410cc1a docs(#130): fix README CLI example and env var table for VCS-agnostic usage

5e20dba3a4 fix(#130): pass VCS_TYPE env var from action.yml Run review step

Compare 5 commits »

rodin created branch review-bot-issue-130-work in rodin/review-bot

2026-05-15 08:59:29 +00:00

rodin commented on pull request rodin/review-bot#151

2026-05-15 08:53:26 +00:00

test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile

Self-Review: PR #151

Self-review against 9b64c605f878eff32e29cc108db360fd64066059

Phase 1: Independent Findings

None — diff looks clean. The refactor correctly moves `validateWorkspaceP…

rodin commented on pull request rodin/review-bot#155

2026-05-15 08:51:43 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

Self-review against 2892dff95dcc48104de02ee99bf66e781f9f0e32

Assessment: ✅ Clean

No issues found — ready for human review.

Checklist:

✅ Coherent: single reason to exist, diff tells a…

rodin pushed to issue-154 at rodin/review-bot

2026-05-15 08:51:24 +00:00

2892dff95d refactor(#154): use flag-name lookup in InvalidRepo and InvalidPRNumber tests

rodin created pull request rodin/review-bot#155

2026-05-15 08:50:32 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

rodin pushed to issue-154 at rodin/review-bot

2026-05-15 08:50:20 +00:00

e718cb841a refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

rodin created branch issue-154 in rodin/review-bot

2026-05-15 08:50:20 +00:00

rodin pushed to issue-143 at rodin/review-bot

2026-05-15 08:39:26 +00:00

3222c765c9 feat(#143): fetch doc-map config from trusted VCS ref

9b64c605f8 fix(#146): reuse resolved doc-map path from early validation in Step 6c

40a16b75e0 test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile

Compare 3 commits »

rodin pushed to issue-150 at rodin/review-bot

2026-05-15 08:37:37 +00:00

4dce8e4454 fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

rodin pushed to main at rodin/model-research

2026-05-15 08:37:02 +00:00

afbc013e2e finding #80: config-a/b dispatcher malfunction detected in multi-model review pipeline (3.5x cost overage)

rodin pushed to issue-146 at rodin/review-bot

2026-05-15 08:36:23 +00:00

9b64c605f8 fix(#146): reuse resolved doc-map path from early validation in Step 6c

rodin commented on pull request rodin/review-bot#151

2026-05-15 08:36:11 +00:00

test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile

Deferred — filed as #154 for a dedicated test-helper refactor pass.