Block a user
test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile
Acknowledging sonnet review NIT #1 (review 4107 @ 9b64c605):
Correct — t.TempDir() is evaluated in the outer (test driver) process before building cmd.Env, so the subprocess receives a…
test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile
Self-review against 9b64c605f878eff32e29cc108db360fd64066059
Assessment: ✅ Clean
No issues found — ready for human review.
Summary: Two-commit PR that (1) moves --doc-map path…
feat(#143): fetch doc-map config from trusted VCS ref
Self-review against 3222c765c948a80d866b349dc8770e7ea9a8b2e1
Assessment: ⚠️ Needs attention
Self-Review: pr-153 — 2026-05-15
Issues Found
- [merge-conflict] PR #153 includes…
feat(#143): fetch doc-map config from trusted VCS ref
Self-review against 3222c765c948a80d866b349dc8770e7ea9a8b2e1
Assessment: ✅ Clean
Security: 🟢
The attack vector is well understood and properly fixed. Fetching the doc-map config from a…