refactor: extract shared base-args helper in main_test.go subprocess tests #154

New Issue

2026-05-15T08:36:05Z

rodin commented

2026-05-15 08:36:05 +00:00

Background

During review of PR #151, sonnet noted that TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile (and other subprocess tests) pass the same required flags verbatim. If the required-flag set changes, multiple tests need updating.

Proposed Change

Extract a baseSubprocessArgs() helper function (similar to cleanEnv()) that returns the base set of required flags for subprocess tests. Each test function appends its own test-specific flags.

This reduces duplication and makes adding/removing required flags a one-line change.

Scope

Mainly cmd/review-bot/main_test.go. Non-trivial refactor since many test functions are involved.

Origin

Deferred from PR #151 fix plan (sonnet NIT finding #2).

## Background During review of PR #151, sonnet noted that `TestMainSubprocess_InvalidDocMapPath` and `TestMainSubprocess_InvalidDocMapFile` (and other subprocess tests) pass the same required flags verbatim. If the required-flag set changes, multiple tests need updating. ## Proposed Change Extract a `baseSubprocessArgs()` helper function (similar to `cleanEnv()`) that returns the base set of required flags for subprocess tests. Each test function appends its own test-specific flags. This reduces duplication and makes adding/removing required flags a one-line change. ## Scope Mainly `cmd/review-bot/main_test.go`. Non-trivial refactor since many test functions are involved. ## Origin Deferred from PR #151 fix plan (sonnet NIT finding #2).

rodin referenced this issue

2026-05-15 08:36:11 +00:00

test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile #151

rodin referenced this issue from a commit

2026-05-15 08:50:20 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

rodin referenced a pull request that will close this issue

2026-05-15 08:50:32 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests #155

rodin referenced this issue from a commit

2026-05-15 08:51:24 +00:00

refactor(#154): use flag-name lookup in InvalidRepo and InvalidPRNumber tests