PR #140: cmd/review-bot coverage at 49.3% — does not meet ≥50% acceptance criterion #147
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was missed
Issue #139 required
cmd/review-botcoverage to improve to ≥50%. PR #140 brought coverage from 44.6% to 49.3%, which is below the stated threshold. The two missing subprocess tests (TestMainSubprocess_InvalidDocMapPathandTestMainSubprocess_InvalidDocMapFile, tracked in #146) are likely the primary gap — adding those tests should push coverage past 50%.Source
cmd/review-botimproves from 44.6% to ≥50%"What needs to happen
go test -coverprofile=coverage.out ./cmd/review-bot/...reports ≥50% coverage for thecmd/review-botpackage.References
🔍 Triage note: This issue depends on #146 (the two missing doc-map subprocess tests). Once #146 is resolved, re-run coverage to see if it crosses 50%. If not, additional test targets will need identification.
Note: this repo has no
blockedlabel to formally track the dependency, but #146 should be addressed first.Coverage is now at 54.1%+ on origin/main (the
validate-docmapsubcommand added in issue #141/PR #142 brought coverage from 49.3% to 54.1%). PR #152 will push it to 54.3%.This issue is resolved — coverage exceeds the >=50% criterion.