Issue #139 required cmd/review-bot coverage to improve to ≥50%. PR #140 brought coverage from 44.6% to 49.3%, which is below the stated threshold. The two missing subprocess tests (TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile, tracked in #146) are likely the primary gap — adding those tests should push coverage past 50%.
Source
PR: #140 — test(#139): improve cmd/review-bot coverage from 44.6% to 49.3%
Acceptance criterion: "Coverage for cmd/review-bot improves from 44.6% to ≥50%"
Actual result: 49.3%
What needs to happen
After adding the missing doc-map subprocess tests (see #146), verify that go test -coverprofile=coverage.out ./cmd/review-bot/... reports ≥50% coverage for the cmd/review-bot package.
If the doc-map tests alone are insufficient, identify and add additional tests for other uncovered branches until coverage reaches ≥50%.
## What was missed
Issue #139 required `cmd/review-bot` coverage to improve to ≥50%. PR #140 brought coverage from 44.6% to 49.3%, which is below the stated threshold. The two missing subprocess tests (`TestMainSubprocess_InvalidDocMapPath` and `TestMainSubprocess_InvalidDocMapFile`, tracked in #146) are likely the primary gap — adding those tests should push coverage past 50%.
## Source
- PR: #140 — test(#139): improve cmd/review-bot coverage from 44.6% to 49.3%
- Linked issue: #139 — test: improve cmd/review-bot coverage
- Acceptance criterion: "Coverage for `cmd/review-bot` improves from 44.6% to ≥50%"
- Actual result: 49.3%
## What needs to happen
- After adding the missing doc-map subprocess tests (see #146), verify that `go test -coverprofile=coverage.out ./cmd/review-bot/...` reports ≥50% coverage for the `cmd/review-bot` package.
- If the doc-map tests alone are insufficient, identify and add additional tests for other uncovered branches until coverage reaches ≥50%.
## References
- [PR #140](https://gitea.weiker.me/rodin/review-bot/pulls/140)
- [Issue #139](https://gitea.weiker.me/rodin/review-bot/issues/139)
- [Issue #146](https://gitea.weiker.me/rodin/review-bot/issues/146) — missing doc-map tests
🔍 Triage note: This issue depends on #146 (the two missing doc-map subprocess tests). Once #146 is resolved, re-run coverage to see if it crosses 50%. If not, additional test targets will need identification.
Note: this repo has no blocked label to formally track the dependency, but #146 should be addressed first.
**🔍 Triage note:** This issue depends on #146 (the two missing doc-map subprocess tests). Once #146 is resolved, re-run coverage to see if it crosses 50%. If not, additional test targets will need identification.
Note: this repo has no `blocked` label to formally track the dependency, but #146 should be addressed first.
rodin
self-assigned this 2026-05-15 08:27:22 +00:00
Coverage is now at 54.1%+ on origin/main (the validate-docmap subcommand added in issue #141/PR #142 brought coverage from 49.3% to 54.1%). PR #152 will push it to 54.3%.
This issue is resolved — coverage exceeds the >=50% criterion.
Coverage is now at 54.1%+ on origin/main (the `validate-docmap` subcommand added in issue #141/PR #142 brought coverage from 49.3% to 54.1%). PR #152 will push it to 54.3%.
This issue is resolved — coverage exceeds the >=50% criterion.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What was missed
Issue #139 required
cmd/review-botcoverage to improve to ≥50%. PR #140 brought coverage from 44.6% to 49.3%, which is below the stated threshold. The two missing subprocess tests (TestMainSubprocess_InvalidDocMapPathandTestMainSubprocess_InvalidDocMapFile, tracked in #146) are likely the primary gap — adding those tests should push coverage past 50%.Source
cmd/review-botimproves from 44.6% to ≥50%"What needs to happen
go test -coverprofile=coverage.out ./cmd/review-bot/...reports ≥50% coverage for thecmd/review-botpackage.References
🔍 Triage note: This issue depends on #146 (the two missing doc-map subprocess tests). Once #146 is resolved, re-run coverage to see if it crosses 50%. If not, additional test targets will need identification.
Note: this repo has no
blockedlabel to formally track the dependency, but #146 should be addressed first.Coverage is now at 54.1%+ on origin/main (the
validate-docmapsubcommand added in issue #141/PR #142 brought coverage from 49.3% to 54.1%). PR #152 will push it to 54.3%.This issue is resolved — coverage exceeds the >=50% criterion.