Rodin

rodin commented on pull request rodin/review-bot#155

2026-05-15 17:17:36 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

Fix Plan against 282b6e0e864627f0cca41ffe7853eb63f6f8b087:

Findings Analysis

Reviews against current HEAD (282b6e0e):

Review 4597 (security): APPROVED, no findings
Review 4598…

rodin pushed to issue-141 at rodin/review-bot

2026-05-15 15:16:00 +00:00

bacb25e029 nit(#141): fix stale-docs error message phrasing

92efd1af2b fix(#141): strip leading './' from coverage-check paths

7adb296523 fix(#141): reject non-regular files in validateDocmapPath

838a34aa12 chore: cycle status 2026-05-15 14:42

6fa3cb9e13 chore(dev-loop): cycle status checkpoint — 2026-05-15 14:26 UTC — steady state, all systems operational

Compare 43 commits »

rodin commented on pull request rodin/review-bot#156

2026-05-15 15:13:13 +00:00

feat(#141): validate-docmap subcommand

Fix Plan against af8b29fa5d9bec667c1b4f182edcd79c10dfe553:

Finding Triage

rodin commented on pull request rodin/review-bot#155

2026-05-15 15:11:58 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

Self-Review: PR #155

Self-review against 282b6e0e864627f0cca41ffe7853eb63f6f8b087

Phase 1: Independent Findings

None — diff looks clean.

The change adds found bool guards + t.Fatal…

rodin pushed to issue-154 at rodin/review-bot

2026-05-15 15:06:25 +00:00

282b6e0e86 nit(#154): add t.Fatal guard if baseSubprocessArgs flag not found

838a34aa12 chore: cycle status 2026-05-15 14:42

6fa3cb9e13 chore(dev-loop): cycle status checkpoint — 2026-05-15 14:26 UTC — steady state, all systems operational

8ab45becec chore(dev-loop): cycle status checkpoint — 2026-05-15 14:18 UTC — steady state, all systems nominal

4311ccfa8f chore(dev-loop): cycle checkpoint — 2026-05-15 13:54 UTC — steady state, all PRs merged, 76.7% coverage

Compare 39 commits »

rodin pushed to issue-154 at rodin/review-bot

2026-05-15 15:00:32 +00:00

64d82cd561 nit(#154): add t.Fatal guard if baseSubprocessArgs flag not found

rodin commented on pull request rodin/review-bot#155

2026-05-15 14:59:53 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

Fix Plan against 2892dff95dcc48104de02ee99bf66e781f9f0e32:

Findings Analysis

Review 4121 (stale, dismissed, old commit e718cb84): MINOR about InvalidPRNumber searching for value…

rodin commented on pull request rodin/review-bot#152

2026-05-15 14:57:35 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Fix Plan against 0723b48ca4c304353789c1ff27012e88009f475f

Addressing self-review findings (all 5 findings resolved):

Finding 1 [NIT] — Dead ModeSymlink check with misleading 'defense-in-dep…

rodin commented on pull request rodin/review-bot#152

2026-05-15 14:55:55 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Fix Plan against `0723b48ca4c304353789c1ff27012e88009f475f`

Addressing self-review findings from 4dce8e4:

Finding 1 [NIT] — Dead ModeSymlink check: removed the unreachable `fi.Mode()&os.Mod…

rodin pushed to issue-150 at rodin/review-bot

2026-05-15 14:55:41 +00:00

0723b48ca4 test(#150): add positive test for in-repo symlink allowed by EvalSymlinks fix

a3dbf91d22 fix(#150): return resolved path from validateDocmapPath to close TOCTOU gap

3f8eb58cac docs(#150): fix stale comments in validateDocmapPath — reflect new in-repo-symlink semantic

Compare 3 commits »

rodin commented on pull request rodin/review-bot#152

2026-05-15 14:49:58 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against 4dce8e4454ee835fd7f611d846b7d6310be0abc0

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#158

2026-05-15 14:49:52 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

Self-review against 6cefbb070e3a730d61ceb37858605d27e75e8a81

Assessment: ✅ Clean

Self-Review: issue-157 — 2026-05-15

Verdict: PASS

No issues found — ready for human review.

**Coheren…

rodin created pull request rodin/review-bot#158

2026-05-15 14:48:55 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

rodin created branch issue-157 in rodin/review-bot

2026-05-15 14:47:59 +00:00

rodin pushed to issue-157 at rodin/review-bot

2026-05-15 14:47:59 +00:00

6cefbb070e fix(#157): add S9 invariant and never-close constraint to dev-loop spec