Rodin

rodin commented on pull request rodin/review-bot#152

2026-05-15 15:02:48 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against 0723b48ca4c304353789c1ff27012e88009f475f

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#152

2026-05-15 15:02:35 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against 0723b48ca4c304353789c1ff27012e88009f475f

Phase 1: Independent Findings

rodin pushed to issue-154 at rodin/review-bot

2026-05-15 15:00:32 +00:00

64d82cd561 nit(#154): add t.Fatal guard if baseSubprocessArgs flag not found

rodin commented on pull request rodin/review-bot#155

2026-05-15 14:59:53 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

Fix Plan against 2892dff95dcc48104de02ee99bf66e781f9f0e32:

Findings Analysis

Review 4121 (stale, dismissed, old commit e718cb84): MINOR about InvalidPRNumber searching for value…

rodin commented on pull request rodin/review-bot#152

2026-05-15 14:57:35 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Fix Plan against 0723b48ca4c304353789c1ff27012e88009f475f

Addressing self-review findings (all 5 findings resolved):

Finding 1 [NIT] — Dead ModeSymlink check with misleading 'defense-in-dep…

rodin commented on pull request rodin/review-bot#152

2026-05-15 14:55:55 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Fix Plan against `0723b48ca4c304353789c1ff27012e88009f475f`

Addressing self-review findings from 4dce8e4:

Finding 1 [NIT] — Dead ModeSymlink check: removed the unreachable `fi.Mode()&os.Mod…

rodin pushed to issue-150 at rodin/review-bot

2026-05-15 14:55:41 +00:00

0723b48ca4 test(#150): add positive test for in-repo symlink allowed by EvalSymlinks fix

a3dbf91d22 fix(#150): return resolved path from validateDocmapPath to close TOCTOU gap

3f8eb58cac docs(#150): fix stale comments in validateDocmapPath — reflect new in-repo-symlink semantic

Compare 3 commits »

rodin commented on pull request rodin/review-bot#152

2026-05-15 14:49:58 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against 4dce8e4454ee835fd7f611d846b7d6310be0abc0

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#158

2026-05-15 14:49:52 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

Self-review against 6cefbb070e3a730d61ceb37858605d27e75e8a81

Assessment: ✅ Clean

Self-Review: issue-157 — 2026-05-15

Verdict: PASS

No issues found — ready for human review.

**Coheren…

rodin created pull request rodin/review-bot#158

2026-05-15 14:48:55 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

rodin created branch issue-157 in rodin/review-bot

2026-05-15 14:47:59 +00:00

rodin pushed to issue-157 at rodin/review-bot

2026-05-15 14:47:59 +00:00

6cefbb070e fix(#157): add S9 invariant and never-close constraint to dev-loop spec

rodin commented on issue rodin/review-bot#157

2026-05-15 14:46:32 +00:00

Bug: dev-loop worker closed PR #156 autonomously

Plan: Issue #157 — Add "never close PR" constraint to spec and tests

Problem

PR #156 was autonomously closed by a worker agent. The dispatch spec forbids merging but did not explicitly…

rodin commented on issue rodin/review-bot#157

2026-05-15 14:45:35 +00:00

Bug: dev-loop worker closed PR #156 autonomously

PR Closure Audit — 2026-05-15

Scope

All closed PRs on rodin/review-bot closed on or after 2026-05-15T00:00:00Z.

PRs Closed Today

rodin reopened pull request rodin/review-bot#152

2026-05-15 14:43:24 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

rodin reopened pull request rodin/review-bot#155

2026-05-15 14:43:24 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

rodin pushed to main at rodin/review-bot

2026-05-15 14:42:28 +00:00

838a34aa12 chore: cycle status 2026-05-15 14:42

rodin opened issue rodin/review-bot#157

2026-05-15 14:40:07 +00:00

Bug: dev-loop worker closed PR #156 autonomously

rodin reopened pull request rodin/review-bot#156

2026-05-15 14:39:50 +00:00

feat(#141): validate-docmap subcommand

rodin created branch review-bot-dev-loop in rodin/review-bot

2026-05-15 14:28:54 +00:00