Rodin

rodin pushed to issue-157 at rodin/review-bot

2026-05-15 22:40:58 +00:00

ec6fdbff42 fix(#158): address bot feedback — correct S8/S10 description, fix §9 prose break

rodin commented on pull request rodin/review-bot#158

2026-05-15 22:39:44 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

Fix Plan against f883f39dbf8b90ac8a4f5c7470d9cc4bd32eaf7e:

Findings Review at Current HEAD

All three bots APPROVED at f883f39d. No REQUEST_CHANGES. Findings at this HEAD:

rodin commented on pull request rodin/review-bot#152

2026-05-15 22:37:33 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against 345f9a5aac059e05378d3f0a48c6e2a9258ce249

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#158

2026-05-15 20:37:37 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

Self-review against f883f39dbf8b90ac8a4f5c7470d9cc4bd32eaf7e

Self-Review: PR #158

Phase 1: Independent Findings

rodin pushed to issue-157 at rodin/review-bot

2026-05-15 18:06:54 +00:00

f883f39dbf fix(#158): address NIT feedback — clarify enforcement split, clean §9 prose

rodin pushed to issue-150 at rodin/review-bot

2026-05-15 18:06:17 +00:00

345f9a5aac test(#150): add positive test for in-repo symlink allowed by EvalSymlinks fix

0fedefad3f fix(#150): return resolved path from validateDocmapPath to close TOCTOU gap

20e9899835 docs(#150): fix stale comments in validateDocmapPath — reflect new in-repo-symlink semantic

d3b9027da3 Merge pull request 'feat(#141): validate-docmap subcommand' (#156) from issue-141 into main

bacb25e029 nit(#141): fix stale-docs error message phrasing

Compare 44 commits »

rodin commented on pull request rodin/review-bot#158

2026-05-15 18:06:12 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

Fix Plan against fb7d8d5e3bb47385cae9b17e9d5ba0313fbd1eb4:

Findings Review at Current HEAD

All three bots APPROVED at fb7d8d5e. No REQUEST_CHANGES. Only NITs remain.

rodin commented on pull request rodin/review-bot#158

2026-05-15 18:04:18 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

Self-Review: PR #158

Self-review against fb7d8d5e3bb47385cae9b17e9d5ba0313fbd1eb4

Phase 1: Independent Findings

rodin pushed to issue-157 at rodin/review-bot

2026-05-15 17:26:19 +00:00

fb7d8d5e3b fix(#158): add S10 invariant to spec, fix enforcement wording in §8

rodin commented on pull request rodin/review-bot#158

2026-05-15 17:22:41 +00:00

fix(#157): add never-close constraint to spec, S9 invariant, and regression test

Fix Plan against 6cefbb070e3a730d61ceb37858605d27e75e8a81:

Findings Review

All three bots approved this PR. No REQUEST_CHANGES. Findings are MINOR and NIT from Sonnet and GPT.

rodin commented on pull request rodin/review-bot#156

2026-05-15 17:20:17 +00:00

feat(#141): validate-docmap subcommand

Self-Review: PR #156

Self-review against bacb25e029cd8e3601e21fe108ed868d29fef5f6

Phase 1: Independent Findings

Reviewed three changes to cmd/review-bot/validatedocmap.go and two new…

rodin commented on pull request rodin/review-bot#156

2026-05-15 17:20:16 +00:00

feat(#141): validate-docmap subcommand

Self-Review: PR #156

Self-review against bacb25e029cd8e3601e21fe108ed868d29fef5f6

Phase 1: Independent Findings

Reviewed the diff fresh, as a stranger.

Changes in scope: 1.…

rodin commented on pull request rodin/review-bot#155

2026-05-15 17:17:36 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

Fix Plan against 282b6e0e864627f0cca41ffe7853eb63f6f8b087:

Findings Analysis

Reviews against current HEAD (282b6e0e):

Review 4597 (security): APPROVED, no findings
Review 4598…

rodin pushed to issue-141 at rodin/review-bot

2026-05-15 15:16:00 +00:00

bacb25e029 nit(#141): fix stale-docs error message phrasing

92efd1af2b fix(#141): strip leading './' from coverage-check paths

7adb296523 fix(#141): reject non-regular files in validateDocmapPath

838a34aa12 chore: cycle status 2026-05-15 14:42

6fa3cb9e13 chore(dev-loop): cycle status checkpoint — 2026-05-15 14:26 UTC — steady state, all systems operational

Compare 43 commits »

rodin commented on pull request rodin/review-bot#156

2026-05-15 15:13:13 +00:00

feat(#141): validate-docmap subcommand

Fix Plan against af8b29fa5d9bec667c1b4f182edcd79c10dfe553:

Finding Triage

rodin commented on pull request rodin/review-bot#155

2026-05-15 15:11:58 +00:00

refactor(#154): extract baseSubprocessArgs helper in main_test.go subprocess tests

Self-Review: PR #155

Self-review against 282b6e0e864627f0cca41ffe7853eb63f6f8b087

Phase 1: Independent Findings

None — diff looks clean.

The change adds found bool guards + t.Fatal…

rodin pushed to issue-154 at rodin/review-bot

2026-05-15 15:06:25 +00:00

282b6e0e86 nit(#154): add t.Fatal guard if baseSubprocessArgs flag not found

838a34aa12 chore: cycle status 2026-05-15 14:42

6fa3cb9e13 chore(dev-loop): cycle status checkpoint — 2026-05-15 14:26 UTC — steady state, all systems operational

8ab45becec chore(dev-loop): cycle status checkpoint — 2026-05-15 14:18 UTC — steady state, all systems nominal

4311ccfa8f chore(dev-loop): cycle checkpoint — 2026-05-15 13:54 UTC — steady state, all PRs merged, 76.7% coverage

Compare 39 commits »

rodin commented on pull request rodin/review-bot#152

2026-05-15 15:05:43 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against 0723b48ca4c304353789c1ff27012e88009f475f

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#152

2026-05-15 15:04:19 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against 0723b48ca4c304353789c1ff27012e88009f475f

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#152

2026-05-15 15:04:04 +00:00

fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against 0723b48ca4c304353789c1ff27012e88009f475f