Rodin

rodin pushed to master at rodin/go-patterns

2026-05-11 15:04:39 +00:00

f070fef8ee fix(citations): correct NewServeMux citation in package-design.md

rodin commented on pull request rodin/review-bot#74

2026-05-11 14:47:18 +00:00

fix(gitea): handle single-object response in ListContents

Addressed [MINOR] finding: guard against empty response in ListContents fallback

Added a defensive check at gitea/client.go:461-464:

// Guard against empty/malformed responses
if…

rodin pushed to issue-73 at rodin/review-bot

2026-05-11 14:47:09 +00:00

c27dfd0f08 fix(gitea): guard against empty response in ListContents fallback

rodin commented on pull request rodin/review-bot#74

2026-05-11 14:32:26 +00:00

fix(gitea): handle single-object response in ListContents

Good question. I verified this against the actual Gitea API:

File path (/api/v1/repos/rodin/review-bot/contents/README.md):

{"name":"README.md","path":"README.md","sha":"cd9fc03889aa…

rodin commented on pull request rodin/review-bot#74

2026-05-11 14:22:32 +00:00

fix(gitea): handle single-object response in ListContents

Self-review: PASS

No issues found — ready for human review.

Summary

Coherence: Single purpose — handle Gitea's single-object response when path is a file.

Fit: Uses existing…

rodin created pull request rodin/review-bot#74

2026-05-11 14:21:52 +00:00

fix(gitea): handle single-object response in ListContents

rodin pushed to issue-73 at rodin/review-bot

2026-05-11 14:21:21 +00:00

1b6c37605f fix(gitea): handle single-object response in ListContents

rodin created branch issue-73 in rodin/review-bot

2026-05-11 14:21:20 +00:00

rodin pushed to issue-70 at rodin/review-bot

2026-05-11 14:12:32 +00:00

ea74f7e088 ci: use rodin/security-patterns with '.' path for security reviewer

rodin pushed to issue-70 at rodin/review-bot

2026-05-11 14:10:57 +00:00

b0349a22a0 ci: add test job for dot path normalization

rodin commented on pull request rodin/review-bot#72

2026-05-11 14:05:23 +00:00

fix(gitea): normalize "." path to empty string in ListContents

Re: Should this be "" or /?

Empty string is correct here. In ListContents, empty string produces:

/api/v1/repos/{owner}/{repo}/contents

(no path suffix), which Gitea handles…

rodin opened issue rodin/review-bot#73

2026-05-11 13:26:49 +00:00

bug: ListContents fails when path is a file (object vs array response)

rodin commented on pull request rodin/review-bot#72

2026-05-11 13:25:09 +00:00

fix(gitea): normalize "." path to empty string in ListContents

Self-review: PASS

Coherence: Single-purpose fix — normalizes . to empty string. No scope creep.

Fit: Matches existing pattern (empty string handling already exists at line 443).…

rodin created pull request rodin/review-bot#72

2026-05-11 13:24:19 +00:00

fix(gitea): normalize "." path to empty string in ListContents

rodin created branch issue-70 in rodin/review-bot

2026-05-11 13:24:12 +00:00

rodin pushed to issue-70 at rodin/review-bot

2026-05-11 13:24:12 +00:00

e6b1840ffc fix(gitea): normalize "." path to empty string in ListContents

rodin opened issue rodin/review-bot#71

2026-05-11 13:15:24 +00:00

bug: patterns-files defaults to README.md instead of fetching all files

rodin opened issue rodin/review-bot#70

2026-05-11 13:15:24 +00:00

bug: patterns-files="." causes 500 error from Gitea API

rodin commented on pull request rodin/review-bot#69

2026-05-11 12:42:36 +00:00

feat(gitea): add retry logic for 5xx errors

Self-review: PASS

No blocking issues found — ready for human review.

Checklist

[gates] All tests pass, go vet clean
[coherence] Single-purpose change: add retry…

rodin commented on pull request rodin/review-bot#69

2026-05-11 12:31:54 +00:00

feat(gitea): add retry logic for 5xx errors

Addressed sonnet review finding #3 (MINOR)

The inconsistency in error returns has been fixed in commit 1b38e6a.

The issue: On the final retry attempt, when a network error occurred, the…