Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin pushed to issue-68 at rodin/review-bot 2026-05-11 12:31:45 +00:00
1b38e6ad00 fix(gitea): ensure consistent lastErr return for network errors
rodin commented on pull request rodin/review-bot#69 2026-05-11 12:15:21 +00:00
feat(gitea): add retry logic for 5xx errors

Addressed MINOR findings from review round

Finding 1: Non-deterministic test (sonnet-review-bot)

Problem: TestDoGet_RetriesOnTemporaryNetError was timing-dependent with no…

rodin pushed to issue-68 at rodin/review-bot 2026-05-11 12:15:12 +00:00
5498dccd60 fix(gitea): address MINOR review findings on retry logic
rodin commented on pull request rodin/review-bot#69 2026-05-11 11:53:01 +00:00
feat(gitea): add retry logic for 5xx errors

Security Finding Addressed

Finding: Retry warnings log the full request URL and the last error, which could inadvertently leak sensitive query parameters if future callers pass them.

**Res…

rodin pushed to issue-68 at rodin/review-bot 2026-05-11 11:52:52 +00:00
ecfbfddc7c fix(gitea): redact query params from retry warning logs
rodin commented on pull request rodin/review-bot#69 2026-05-11 11:32:34 +00:00
feat(gitea): add retry logic for 5xx errors

Addressed Review Feedback (commit ac53ecf)

Addressed all MINOR findings from the previous review:

Fixed

1. isTemporaryNetError too broad (sonnet line ~277, gpt line ~234)

  • Now…
rodin pushed to issue-68 at rodin/review-bot 2026-05-11 11:32:21 +00:00
ac53ecfa5d fix(gitea): improve retry logic precision for net.OpError
rodin commented on pull request rodin/review-bot#69 2026-05-11 11:23:41 +00:00
feat(gitea): add retry logic for 5xx errors

Review Feedback Addressed (round 2)

Addressed the two MINOR findings from gpt-review-bot:

1. Configurable Backoff Durations

Added RetryBackoff field to Client struct:

  • Defaults to…
rodin pushed to issue-68 at rodin/review-bot 2026-05-11 11:23:32 +00:00
090ae3848c fix(gitea): make retry backoff configurable and retry temp net errors
rodin commented on pull request rodin/review-bot#69 2026-05-11 08:08:20 +00:00
feat(gitea): add retry logic for 5xx errors

Review Feedback Addressed

Fixed (commit 23da7ee)

  1. Dead backoff[0] element (sonnet-review + gpt-review NIT)
    • Removed the unused 0 duration from the backoff slice
    • Array now…
rodin pushed to issue-68 at rodin/review-bot 2026-05-11 08:08:08 +00:00
23da7eedf5 fix(gitea): address review feedback on retry logic
rodin commented on pull request rodin/review-bot#69 2026-05-11 08:01:40 +00:00
feat(gitea): add retry logic for 5xx errors

Self-review: PASS

No issues found — ready for human review.

Gates: All pass (make precommit succeeds)

Coherence: Single-purpose change — retry logic for 5xx errors. Every line…

rodin created pull request rodin/review-bot#69 2026-05-11 08:00:23 +00:00
feat(gitea): add retry logic for 5xx errors
rodin pushed to issue-68 at rodin/review-bot 2026-05-11 07:59:55 +00:00
7279cdd216 feat(gitea): add retry logic for 5xx errors in doGet
rodin created branch issue-68 in rodin/review-bot 2026-05-11 07:59:55 +00:00
rodin opened issue rodin/review-bot#68 2026-05-11 07:47:50 +00:00
Add retry logic for pattern fetch API calls
rodin pushed to master at rodin/ddd-patterns 2026-05-11 07:29:59 +00:00
b72c14f370 refocus on LLM mistakes, not textbook definitions
rodin pushed to main at rodin/model-research 2026-05-11 07:29:26 +00:00
ac55ecdb98 Finding 28: Regulatory compliance analysis on wash sale tracking
rodin pushed to master at rodin/ddd-patterns 2026-05-11 07:27:35 +00:00
d68d1697aa Initial DDD and event sourcing review patterns
rodin created branch master in rodin/ddd-patterns 2026-05-11 07:27:35 +00:00