rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

bug: patterns-files defaults to README.md instead of fetching all files #71

New Issue
Closed
opened 2026-05-11 13:15:24 +00:00 by rodin · 0 comments
rodin commented 2026-05-11 13:15:24 +00:00
Owner
Copy Link
Copy Source

Problem

The default for patterns-files is README.md:

patternsFiles := flag.String("patterns-files", envOrDefault("PATTERNS_FILES", "README.md"), ...)

This means if you set patterns-repo but omit patterns-files, you only get the README — not the actual pattern files.

Expected Behavior

The common case is "fetch all pattern files from the repo". Users who set patterns-repo: rodin/security-patterns expect to get all 20+ pattern files, not just the README.

Fix

Change default from README.md to "" (empty string), which fetches all files in the repo root.

patternsFiles := flag.String("patterns-files", envOrDefault("PATTERNS_FILES", ""), ...)

Users who only want specific files can still set patterns-files: README.md,patterns/foo.md explicitly.

## Problem The default for `patterns-files` is `README.md`: ```go patternsFiles := flag.String("patterns-files", envOrDefault("PATTERNS_FILES", "README.md"), ...) ``` This means if you set `patterns-repo` but omit `patterns-files`, you only get the README — not the actual pattern files. ## Expected Behavior The common case is "fetch all pattern files from the repo". Users who set `patterns-repo: rodin/security-patterns` expect to get all 20+ pattern files, not just the README. ## Fix Change default from `README.md` to `""` (empty string), which fetches all files in the repo root. ```go patternsFiles := flag.String("patterns-files", envOrDefault("PATTERNS_FILES", ""), ...) ``` Users who only want specific files can still set `patterns-files: README.md,patterns/foo.md` explicitly.
rodin closed this issue 2026-05-11 17:45:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#71
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?