Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin commented on pull request rodin/review-bot#103 2026-05-13 06:09:16 +00:00
feat(github): implement FileReader interface

Addressing Inline Review Findings

Resolving all inline comment threads. Here is the rationale for each finding that was marked as a design choice rather than a defect:

Review 3025…

rodin commented on pull request rodin/review-bot#103 2026-05-13 06:08:01 +00:00
feat(github): implement FileReader interface

Intentionally scoped locally — entry is only meaningful within ListContents and keeping it inside the function avoids polluting the package namespace with a one-off decode struct.

rodin commented on pull request rodin/review-bot#103 2026-05-13 06:07:36 +00:00
feat(github): implement FileReader interface

Intentionally scoped locally — entry is only meaningful within ListContents and keeping it inside the function avoids polluting the package namespace with a one-off decode struct.

rodin commented on pull request rodin/review-bot#103 2026-05-13 06:07:18 +00:00
feat(github): implement FileReader interface

Intentionally scoped locally — entry is only meaningful within ListContents and keeping it inside the function avoids polluting the package namespace with a one-off decode struct.

rodin commented on pull request rodin/review-bot#103 2026-05-13 05:58:46 +00:00
feat(github): implement FileReader interface

Self-Review: PR #103

Self-review against dca260f5820350cbb3477b5789dbeacc2fd3c840

Phase 1: Independent Findings

None — diff looks clean.

The implementation is well-structured: -…

rodin pushed to issue-80-c-file-reader at rodin/review-bot 2026-05-13 05:47:37 +00:00
dca260f582 fix(test): SetRetryBackoff with correct slice length
rodin commented on pull request rodin/review-bot#103 2026-05-13 05:42:34 +00:00
feat(github): implement FileReader interface

Self-Review: PR #103

Self-review against 921599542db0d05d9bb4180ddbca80b4a581dcf5

Phase 1: Independent Findings

**1. [MINOR] SetRetryBackoff called with wrong slice length in new…

rodin pushed to issue-80-c-file-reader at rodin/review-bot 2026-05-13 05:33:52 +00:00
921599542d feat(github): implement FileReader interface (#80)
71bb33b6fd Merge pull request 'feat(github): implement PRReader interface' (#102) from issue-80-b-pr-reader into feature/github-support
55366b3431 fix: address review feedback on PRReader implementation
3cd5ae594e fix(github): escapePath returns error on dot-segments, fix Description semantics
eaccc96073 fix: address review feedback on PR #102
Compare 7 commits »
rodin commented on pull request rodin/review-bot#102 2026-05-13 05:26:13 +00:00
feat(github): implement PRReader interface

Self-Review: PR #102

Self-review against 55366b3431d3ec2417d1bb087398ff4e0895effe

Phase 1: Independent Findings

Reviewing this diff as a stranger who hasn't seen this code before.

**Chang…

rodin pushed to issue-80-b-pr-reader at rodin/review-bot 2026-05-13 05:17:38 +00:00
55366b3431 fix: address review feedback on PRReader implementation
rodin commented on pull request rodin/review-bot#102 2026-05-13 05:10:39 +00:00
feat(github): implement PRReader interface

Self-Review: PR #102

Self-review against 3cd5ae594e9d7a12486eb9980c3ca44225aeb507

Phase 1: Independent Findings

Reviewing as a stranger to this code:

  1. **[NIT] github/files_test.go —…
rodin pushed to issue-80-b-pr-reader at rodin/review-bot 2026-05-13 05:03:57 +00:00
3cd5ae594e fix(github): escapePath returns error on dot-segments, fix Description semantics
rodin commented on pull request rodin/review-bot#102 2026-05-13 04:55:58 +00:00
feat(github): implement PRReader interface

Self-Review: PR #102

Self-review against eaccc9607375f721b40799201d9dc814ba7dbdc8

Phase 1: Independent Findings

  1. **[MINOR] github/files.go — escapePath silently rewrites paths with…
rodin commented on pull request rodin/review-bot#103 2026-05-13 04:46:45 +00:00
feat(github): implement FileReader interface

Self-Review: PR #103

Self-review against 7eeb3147dbf9bd52f786b1cf066d9e0abecd89c3

Phase 1: Independent Findings

1. [MINOR] escapePath path traversal semantics vs documentation The…

rodin commented on pull request rodin/review-bot#102 2026-05-13 04:42:52 +00:00
feat(github): implement PRReader interface

Self-Review: PR #102

Self-review against 329d68e4b41dae2b3d7dc77cd61451237bff2ea1

Phase 1: Independent Findings

  1. **[MINOR] github/pr.go — CommitStatus.Description semantic mismatch…
rodin pushed to issue-80-b-pr-reader at rodin/review-bot 2026-05-13 04:36:50 +00:00
329d68e4b4 fix: address review feedback on PR #102
rodin commented on pull request rodin/review-bot#101 2026-05-13 04:32:00 +00:00
feat(github): implement GitHub API client foundation

Re gpt-review-bot findings (commit 61819ac):

  • MAJOR #1 (panic on backoff misconfiguration): Fixed — removed the panic from doRequest. Validation now happens in SetRetryBackoff which…
rodin pushed to issue-80-a-client at rodin/review-bot 2026-05-13 04:31:49 +00:00
61819ac3e3 fix(github): address review findings - remove panic, validate at config time
rodin commented on pull request rodin/review-bot#101 2026-05-13 04:27:13 +00:00
feat(github): implement GitHub API client foundation

Re NITs:

  • timer.Stop() after fire (id:18031): Agreed, kept as-is — the comment explains the intent.
  • RetryAfterDoesNotMutateBackoff skip guard (id:18030): Fair point about using…
rodin commented on pull request rodin/review-bot#101 2026-05-13 04:27:06 +00:00
feat(github): implement GitHub API client foundation

Addressed the two MINOR findings. See commit 3d1260d.