Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin commented on pull request rodin/review-bot#101 2026-05-13 04:27:06 +00:00
feat(github): implement GitHub API client foundation

Fixed. Added a panic guard ensuring len(backoff) == maxAttempts-1. If someone changes maxAttempts without updating the default backoff, this fires immediately in tests rather than silently producing incorrect retry behavior.

rodin commented on pull request rodin/review-bot#101 2026-05-13 04:27:06 +00:00
feat(github): implement GitHub API client foundation

Fixed. Now capturing resp.StatusCode and Retry-After header into local variables before calling handleResponse, making the ownership transfer explicit. The caller no longer touches resp after handing it off.

rodin pushed to issue-80-a-client at rodin/review-bot 2026-05-13 04:26:44 +00:00
3d1260d3b2 fix(github): clarify response ownership and validate backoff length
rodin pushed to issue-80-b-pr-reader at rodin/review-bot 2026-05-13 04:21:07 +00:00
3995fa3136 fix(github): add GetFileContentAtRef and fix conformance test
rodin commented on pull request rodin/review-bot#93 2026-05-13 04:19:40 +00:00
feat(github): implement PRReader + FileReader client (#80)

Addressed findings from reviews #2955 and #2958 in commit 6316007:

Fixed:

  • [MINOR] handleResponse → package-level function (no receiver needed) — comment 17955
  • [MINOR] Added clarifying…
rodin pushed to review-bot-issue-80 at rodin/review-bot 2026-05-13 04:19:08 +00:00
6316007eb1 fix: address review findings from reviews #2955 and #2958
rodin commented on pull request rodin/review-bot#93 2026-05-13 04:15:37 +00:00
feat(github): implement PRReader + FileReader client (#80)

Split into 3 focused PRs for easier review:

  • PR #101 — Client Foundation (vcs/types.go, github/client.go, github/client_test.go)
  • PR #102 — PRReader interface (github/pr.go,…
rodin closed pull request rodin/review-bot#93 2026-05-13 04:15:37 +00:00
feat(github): implement PRReader + FileReader client (#80)
rodin closed issue rodin/review-bot#80 2026-05-13 04:13:12 +00:00
feat(github): PRReader + FileReader client (Phase 3)
rodin commented on issue rodin/review-bot#80 2026-05-13 04:13:09 +00:00
feat(github): PRReader + FileReader client (Phase 3)

Split into sub-issues for focused review:

  • #98 — Client Foundation (vcs/types.go, github/client.go, github/client_test.go) → PR #101
  • #99 — PRReader interface (github/pr.go,…
rodin created pull request rodin/review-bot#103 2026-05-13 04:13:04 +00:00
feat(github): implement FileReader interface
rodin pushed to issue-80-c-file-reader at rodin/review-bot 2026-05-13 04:13:00 +00:00
7eeb3147db feat(github): implement FileReader interface (#80)
rodin created branch issue-80-c-file-reader in rodin/review-bot 2026-05-13 04:13:00 +00:00
rodin created pull request rodin/review-bot#102 2026-05-13 04:12:47 +00:00
feat(github): implement PRReader interface
rodin created pull request rodin/review-bot#101 2026-05-13 04:12:42 +00:00
feat(github): implement GitHub API client foundation
rodin opened issue rodin/review-bot#100 2026-05-13 04:12:37 +00:00
feat(github): implement FileReader interface
rodin opened issue rodin/review-bot#99 2026-05-13 04:12:33 +00:00
feat(github): implement PRReader interface
rodin opened issue rodin/review-bot#98 2026-05-13 04:12:29 +00:00
feat(github): implement GitHub API client foundation
rodin pushed to issue-80-b-pr-reader at rodin/review-bot 2026-05-13 04:12:15 +00:00
d468ea6022 feat(github): implement PRReader interface (#80)
rodin created branch issue-80-b-pr-reader in rodin/review-bot 2026-05-13 04:12:15 +00:00