Rodin

rodin commented on pull request rodin/review-bot#105

2026-05-13 08:29:34 +00:00

feat(github): implement Reviewer and Identity interfaces (#81)

Re: inline comment on github/review.go (Finding 1, comment #18538)

Fixed in 8413665. Rewrote the PostReview doc comment to:

Explicitly reference vcs.ReviewEvent constants and their string…

rodin pushed to review-bot-issue-81 at rodin/review-bot

2026-05-13 08:29:20 +00:00

8413665638 fix(github): clarify PostReview doc comment, rename test field to 'want'

rodin created pull request rodin/review-bot#106

2026-05-13 08:21:49 +00:00

feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

rodin pushed to review-bot-issue-82 at rodin/review-bot

2026-05-13 08:21:38 +00:00

7d0d3ea885 feat(cmd): wire --provider and --base-url flags into CLI

rodin created branch review-bot-issue-82 in rodin/review-bot

2026-05-13 08:21:38 +00:00

rodin commented on pull request rodin/review-bot#105

2026-05-13 08:02:41 +00:00

feat(github): implement Reviewer and Identity interfaces (#81)

Self-Review: PR #105

Self-review against 20cfb33cdd2ab973031230d2184f690484285e8e

Phase 1: Independent Findings

The incremental changes (84cc23c → 20cfb33c) address all findings from the…

rodin pushed to review-bot-issue-81 at rodin/review-bot

2026-05-13 07:54:26 +00:00

20cfb33cdd address review feedback: wrap ErrCannotDeleteSubmittedReview, fix nits

rodin commented on pull request rodin/review-bot#105

2026-05-13 07:42:59 +00:00

feat(github): implement Reviewer and Identity interfaces (#81)

Self-Review: PR #105

Self-review against 84cc23c7e983330f78c294477f4be73fcd633837

Phase 1: Independent Findings

**1. [NIT] github/review.go ~line 83 — Double iteration over `req.Comment…

rodin pushed to review-bot-issue-81 at rodin/review-bot

2026-05-13 07:36:07 +00:00

84cc23c7e9 refactor(github): extract doRequestCore, address review feedback

rodin created pull request rodin/review-bot#105

2026-05-13 07:26:05 +00:00

feat(github): implement Reviewer and Identity interfaces (#81)

rodin pushed to review-bot-issue-81 at rodin/review-bot

2026-05-13 07:25:55 +00:00

118e9df758 feat(github): implement Reviewer and Identity interfaces (#81)

rodin created branch review-bot-issue-81 in rodin/review-bot

2026-05-13 07:25:55 +00:00

rodin commented on pull request rodin/review-bot#104

2026-05-13 06:33:25 +00:00

fix(gitea): map hunk-header positions in BuildPositionToLineMap

Self-Review: PR #104

Self-review against 02bdd701a56651aeb1ae7a9e35e2f20b3ed055f9

Phase 1: Independent Findings

None — diff looks clean. The new test follows the same pattern as…

rodin commented on pull request rodin/review-bot#104

2026-05-13 06:32:51 +00:00

fix(gitea): map hunk-header positions in BuildPositionToLineMap

Good catch — added TestTranslate_HunkHeaderAtEnd in commit 02bdd70. This covers the edge case where a hunk-header is the last position in the file with no subsequent new-file line, mirroring…

rodin commented on pull request rodin/review-bot#104

2026-05-13 06:32:45 +00:00

fix(gitea): map hunk-header positions in BuildPositionToLineMap

Acknowledged — I'll push back on this one.

The if/else structure is intentional idiomatic Go: a single if lineNum <= 0 guard gates the shared forward-walk logic, and the error messages at the…

rodin pushed to review-bot-issue-97 at rodin/review-bot

2026-05-13 06:32:27 +00:00

02bdd701a5 test(gitea): add hunk-header-at-end error path test

rodin commented on pull request rodin/review-bot#104

2026-05-13 06:21:51 +00:00

fix(gitea): map hunk-header positions in BuildPositionToLineMap

Self-Review: PR #104

Self-review against 23dc781908541cd9971785818dc5bde4f5fb71f7

Phase 1: Independent Findings

None — diff looks clean. The sentinel value approach (0 for hunk-headers,…

rodin created pull request rodin/review-bot#104

2026-05-13 06:13:46 +00:00

fix(gitea): map hunk-header positions in BuildPositionToLineMap

rodin pushed to review-bot-issue-97 at rodin/review-bot

2026-05-13 06:13:33 +00:00

23dc781908 fix(gitea): map hunk-header positions in BuildPositionToLineMap

rodin created branch review-bot-issue-97 in rodin/review-bot

2026-05-13 06:13:33 +00:00