Rodin

rodin commented on pull request rodin/review-bot#106

2026-05-13 14:13:38 +00:00

feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Re: Comment 18958 (unreachable default case):

✅ Fixed in e72bda0. Removed the unreachable default case entirely — the provider validation switch above (line 113) guarantees only valid…

rodin commented on pull request rodin/review-bot#106

2026-05-13 14:13:38 +00:00

feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Re: Comment 18957 (supersedeOldReviews type assertion):

Acknowledged — pushing back on this one. The type assertion for *gitea.Adapter in supersedeOldReviews is the accepted pattern…

rodin pushed to review-bot-issue-82 at rodin/review-bot

2026-05-13 14:13:18 +00:00

e72bda0110 fix: address review feedback — gofmt NITs and remove unreachable default

rodin commented on pull request rodin/review-bot#106

2026-05-13 14:11:03 +00:00

feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Fix Plan against 8eeab963645b58f4f296ef7eaaf35864ebba90e5:

Findings to Address

From Self-Review (comment 19441) — 4 NITs:

rodin commented on pull request rodin/review-bot#110

2026-05-13 14:04:09 +00:00

feat(github): support HTTP-date format in Retry-After header

Self-Review: PR #110

Self-review against 9f8e9aa8d3c1d641d608ca8d1f7b5dea8f2d1688

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#106

2026-05-13 14:02:44 +00:00

feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Self-Review: PR #106

Self-review against 8eeab963645b58f4f296ef7eaaf35864ebba90e5

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#109

2026-05-13 13:54:18 +00:00

feat(gitea): harden GetPullRequestDiff against unbounded diff size

Self-Review: PR #109

Self-review against 49d6ca77a386c31106676f112b6fdc23b88fb360

Phase 1: Independent Findings

**1. [NIT] Overflow-guard comment in doGetLimited describes unreachable…

rodin pushed to review-bot-issue-82 at rodin/review-bot

2026-05-13 13:47:46 +00:00

8eeab96364 fix(cmd): remove duplicate doc comment and double blank line

b7f108faf6 docs(cmd,github): clarify type assertion and parameter usage in review superseding

528d29b63d fix: address self-review findings

0e503357ed fix: address review feedback on PR #106

f50920333f fix(review): address bot review feedback on PR #106

Compare 67 commits »

rodin pushed to review-bot-issue-82 at rodin/review-bot

2026-05-13 13:43:51 +00:00

8c3c9968de fix(cmd): remove duplicate doc comment and double blank line

d4d369798c docs(cmd,github): clarify type assertion and parameter usage in review superseding

ce1d9760d9 fix: address self-review findings

c81698efb1 fix: address review feedback on PR #106

83a538f138 fix(review): address bot review feedback on PR #106

Compare 52 commits »

rodin commented on pull request rodin/review-bot#105

2026-05-13 13:31:07 +00:00

feat(github): implement Reviewer and Identity interfaces (#81)

Self-Review: PR #105

Self-review against 027bad2f7cbaa314c7e04d515baaef4d67b79c92

Phase 1: Independent Findings

Reviewing the github/ changes at the current HEAD as a stranger…

rodin commented on pull request rodin/review-bot#110

2026-05-13 13:22:42 +00:00

feat(github): support HTTP-date format in Retry-After header

Self-review findings addressed (commit 9f8e9aa)

Timer leak on normal path — Added timer.Stop() to the case <-timer.C branch in doRequest. Both select branches now call Stop(),…

rodin pushed to review-bot-issue-94 at rodin/review-bot

2026-05-13 13:22:35 +00:00

9f8e9aa8d3 fix: timer leak and http field shadowing in github client

rodin commented on pull request rodin/review-bot#110

2026-05-13 13:15:34 +00:00

feat(github): support HTTP-date format in Retry-After header

Self-Review: PR #110

Self-review against 31a28b1dd5428c16878153be49cff668f4da5a7e

Phase 1: Independent Findings

rodin pushed to review-bot-issue-94 at rodin/review-bot

2026-05-13 13:08:53 +00:00

31a28b1dd5 address review feedback: baseURL TODO, timer-cancel test, fast retry test, doc note

rodin commented on pull request rodin/review-bot#110

2026-05-13 13:03:23 +00:00

feat(github): support HTTP-date format in Retry-After header

Self-Review: PR #110

Self-review against e414471a162d4fd83160c0059f4bd33e8dd8a1c5

Phase 1: Independent Findings

rodin pushed to review-bot-issue-94 at rodin/review-bot

2026-05-13 12:54:11 +00:00

e414471a16 fix(github): address review feedback on Retry-After implementation

rodin commented on pull request rodin/review-bot#109

2026-05-13 12:48:04 +00:00

feat(gitea): harden GetPullRequestDiff against unbounded diff size

Self-Review: PR #109

Self-review against 1f0636e1403acc72bf902d6e1a52cb3416589142

Phase 1: Independent Findings

1. [NIT] doGetLimited overflow guard is now dead code (`gitea/client.g…

rodin commented on pull request rodin/review-bot#109

2026-05-13 12:41:16 +00:00

feat(gitea): harden GetPullRequestDiff against unbounded diff size

Review feedback addressed (1f0636e)

[MINOR] doGetLimited duplicates retry/backoff logic (sonnet, gpt, all reviewers)

Fixed. Extracted doGetWithReader as a shared core that accepts a…

rodin pushed to review-bot-issue-92 at rodin/review-bot

2026-05-13 12:40:54 +00:00

1f0636e140 refactor(gitea): eliminate retry duplication, harden redactURL and MaxInt64 edge case

rodin commented on pull request rodin/review-bot#109

2026-05-13 12:31:39 +00:00

feat(gitea): harden GetPullRequestDiff against unbounded diff size

Self-Review: PR #109

Self-review against 84ac50a8cffdb79df34f554e30a0079a40f465d6

Phase 1: Independent Findings

1. [MINOR] doGetLimited duplicates retry/backoff logic from doGet…