Fixed in 84ac50a — consolidated all six individual test functions into a single table-driven TestGetPullRequestDiff_SizeLimits test with named subtests.
Fixed in 84ac50a — added the same concurrency safety note that RetryBackoff has: "This field must be configured before the first request is made. Modifying it while requests are in flight is…
Already fixed in the previous commit — see comment. The overflow clamp (`if limitBytes <= 0 { limitBytes = math.MaxInt64…
Same as sonnet finding — acknowledged as a follow-up refactor. See prior comment.
Not applicable here. The Client struct has unexported fields (baseURL, token, http), so no external package can use unkeyed composite literals — the compiler already rejects it. Only…
Acknowledged as a follow-up refactor (see prior comment). All three reviews approved with this accepted as future work.
Added //nolint:errcheck annotation to the test handler w.Write call in the table-driven rewrite for clarity.
Thanks for confirming the consistency — no change needed here.
Review findings addressed
1. maxBytes+1 integer overflow (security-review-bot)
Fixed. Added overflow clamp before passing to io.LimitReader:
limitBytes := maxBytes + 1
if…
Self-Review: PR #109
Self-review against 235828ec4233fb71a0558255383ca1d30917826a
Phase 1: Independent Findings
- **[MINOR]
doGetLimitedduplicates ~65 lines of retry logic from…
Self-Review: PR #106
Self-review against 696b986ec7215906bde290b5938760be7d356fe0
Phase 1: Independent Findings