Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin commented on pull request rodin/review-bot#106 2026-05-13 16:13:05 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Self-Review: PR #106

Self-review against ac6d34f5bd09cb340db87acee6f34c1c2c504f53

Phase 1: Independent Findings

None — diff looks clean.

The refactor correctly introduces `vcs.VCSProvide…

rodin commented on pull request rodin/review-bot#111 2026-05-13 16:05:57 +00:00
feat: reject cross-host redirects and HTTPS→HTTP downgrades (#95)

Self-Review: PR #111

Self-review against 1e0959b077bd0b06807ea984ba17dd137b8023f9

Phase 1: Independent Findings

None — diff looks clean. The implementation is correct, well-structured,…

rodin pushed to review-bot-issue-82 at rodin/review-bot 2026-05-13 16:03:48 +00:00
ac6d34f5bd fix: address review feedback - eliminate type assertion via ReviewSuperseder interface
rodin commented on pull request rodin/review-bot#106 2026-05-13 15:58:30 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Fix Plan against 34f73938925d37f89d96613f3e1c93010e8c9a73:

Findings Analysis

rodin created pull request rodin/review-bot#111 2026-05-13 15:51:55 +00:00
feat: reject cross-host redirects and HTTPS→HTTP downgrades (#95)
rodin created branch review-bot-issue-95 in rodin/review-bot 2026-05-13 15:51:41 +00:00
rodin pushed to review-bot-issue-95 at rodin/review-bot 2026-05-13 15:51:41 +00:00
1e0959b077 feat: reject cross-host redirects and HTTPS→HTTP downgrades (#95)
rodin pushed to review-bot-issue-82 at rodin/review-bot 2026-05-13 15:48:40 +00:00
34f7393892 fix: address review feedback on PR #106
bdc109901d fix(github): remove double blank line in client_test.go (gofmt)
271ea7f5fe style: remove stray blank line in doRequestWithBody
e70b54f238 fix: address review feedback — gofmt NITs and remove unreachable default
c5bc807d2c fix(cmd): remove duplicate doc comment and double blank line
Compare 14 commits »
rodin commented on issue rodin/review-bot#95 2026-05-13 15:47:44 +00:00
Reject cross-host redirects and HTTPS→HTTP downgrades entirely

Plan: Reject cross-host redirects and HTTPS→HTTP downgrades entirely### ProblemThe GitHub client's defaultCheckRedirect currently:1. ✅ Rejects HTTPS→HTTP downgrades (returns error)2. ⚠️…

rodin commented on pull request rodin/review-bot#106 2026-05-13 15:14:47 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Self-Review: PR #106

Self-review against e7efbe22045bee33608aff6e913ec1fc2ccd7cf8

Phase 1: Independent Findings

None — diff looks clean.

The latest commit (e7efbe2, since last clean…

rodin pushed to review-bot-issue-82 at rodin/review-bot 2026-05-13 15:01:20 +00:00
e7efbe2204 fix: address review feedback on PR #106
rodin commented on pull request rodin/review-bot#106 2026-05-13 14:56:17 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Fix Plan against d9179c27ea0bf317b9c2e3f6f934aa811ef05afe:

Findings & Categorization

rodin commented on pull request rodin/review-bot#106 2026-05-13 14:52:59 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Self-Review: PR #106

Self-review against d9179c27ea0bf317b9c2e3f6f934aa811ef05afe

Phase 1: Independent Findings

None — diff looks clean.

Reviewed all changed files:

  • `cmd/review-bot/mai…
rodin pushed to review-bot-issue-82 at rodin/review-bot 2026-05-13 14:45:22 +00:00
d9179c27ea fix(github): remove double blank line in client_test.go (gofmt)
rodin commented on pull request rodin/review-bot#106 2026-05-13 14:44:40 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Fix Plan against 8e3c31cce7f5f1e4916693cad68fe9f6676e5e19:

Finding: Double blank line in github/client_test.go before TestSetRetryBackoff_RejectsInvalidLength

Fix: Remove one of…

rodin commented on pull request rodin/review-bot#106 2026-05-13 14:38:42 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Self-Review: PR #106

Self-review against 8e3c31cce7f5f1e4916693cad68fe9f6676e5e19

Phase 1: Independent Findings

rodin commented on pull request rodin/review-bot#106 2026-05-13 14:29:37 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Fixed in HEAD (8e3c31c) — removed stray blank line before closing } of doRequestWithBody in github/client.go.

rodin pushed to review-bot-issue-82 at rodin/review-bot 2026-05-13 14:29:33 +00:00
8e3c31cce7 style: remove stray blank line in doRequestWithBody
rodin commented on pull request rodin/review-bot#106 2026-05-13 14:25:14 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Fix Plan against e72bda011097f65d94ee61936003130e0571e76f:

Finding: [NIT] github/client.go — Stray blank line inside doRequestWithBody

Location: github/client.go, line 387 (blank…

rodin commented on pull request rodin/review-bot#106 2026-05-13 14:23:02 +00:00
feat(cmd): wire --provider and --base-url flags into CLI (Phase 5)

Self-Review: PR #106

Self-review against e72bda011097f65d94ee61936003130e0571e76f

Phase 1: Independent Findings