Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin created branch review-bot-issue-114 in rodin/review-bot 2026-05-13 20:30:54 +00:00
rodin pushed to review-bot-issue-114 at rodin/review-bot 2026-05-13 20:30:54 +00:00
7e3b6ec8f1 fix(vcs): thread CommitID through abstraction layer (#114)
rodin commented on issue rodin/review-bot#114 2026-05-13 20:24:39 +00:00
PR #112: gitea.Adapter.PostReview bypasses commitID — abstraction layer drops commit anchor

Plan: Thread CommitID through the VCS abstraction layer

Problem

PR #112 added commitID support to gitea.Client.PostReview at the transport level but never connected it to the…

rodin commented on pull request rodin/review-bot#113 2026-05-13 20:14:06 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Self-Review: PR #113

Self-review against ab2a6c8aeff8d5afbf8aea4cbcbdeab774750ed4

Phase 1: Independent Findings

Reviewing the diff as a stranger. Three files changed: github/client.go…

rodin commented on pull request rodin/review-bot#113 2026-05-13 20:10:11 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Self-Review: PR #113

Self-review against ab2a6c8aeff8d5afbf8aea4cbcbdeab774750ed4

Phase 1: Independent Findings

Reviewing the diff as a stranger to this codebase. Three files changed:…

rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 20:04:29 +00:00
ab2a6c8aef Address review feedback on PR #113
rodin commented on pull request rodin/review-bot#113 2026-05-13 20:03:17 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fix Plan against 6b7f3f6924e384f36d38e1c638672c02e784ed91:

MINOR #1 (comment 20099) — FIX

Issue: AllowInsecureHTTP() doc comment says "defined in export_test.go" which misrepresents…

rodin commented on pull request rodin/review-bot#113 2026-05-13 19:57:58 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Self-Review: PR #113

Self-review against 6b7f3f6924e384f36d38e1c638672c02e784ed91

Phase 1: Independent Findings

Reviewing the diff as a stranger: 3 files changed — github/client.go…

rodin commented on pull request rodin/review-bot#113 2026-05-13 19:48:31 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Addressed all NITs.

rodin commented on pull request rodin/review-bot#113 2026-05-13 19:48:24 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Added a clarifying comment acknowledging the double parse is acceptable.

rodin commented on pull request rodin/review-bot#113 2026-05-13 19:48:24 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fixed: removed 'silently' from the doc comment since the code logs slog.Warn.

rodin commented on pull request rodin/review-bot#113 2026-05-13 19:48:24 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Simplified to unconditional u.User = nil.

rodin commented on pull request rodin/review-bot#113 2026-05-13 19:48:17 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Addressed all 3 NITs in commit 6b7f3f6:

  • NIT 20039: Fixed doc comment — removed "silently" since we actually log a warning
  • NIT 20040: Simplified to unconditional u.User = nil
  • **NIT…
rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 19:48:07 +00:00
6b7f3f6924 fix: address NIT findings from sonnet review (#113)
rodin commented on pull request rodin/review-bot#113 2026-05-13 19:46:43 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fix Plan against 4c032a3b5354b2ee58cc03a22297c941a3e0d2e8:

NIT 20039: Fix AllowInsecureHTTP() doc comment

The doc says "silently ignored" but the code logs slog.Warn. Will change the…

rodin opened issue rodin/review-bot#116 2026-05-13 19:07:57 +00:00
Build broken: github/reviews.go duplicates github/review.go — redeclared types and methods
rodin opened issue rodin/review-bot#115 2026-05-13 19:07:32 +00:00
PR #112: vcs.ReviewRequest.CommitID field missing — issue #107's interface-level fix not implemented
rodin opened issue rodin/review-bot#114 2026-05-13 19:07:20 +00:00
PR #112: gitea.Adapter.PostReview bypasses commitID — abstraction layer drops commit anchor
rodin commented on pull request rodin/review-bot#113 2026-05-13 19:03:01 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Self-Review: PR #113

Self-review against 4c032a3b5354b2ee58cc03a22297c941a3e0d2e8

Phase 1: Independent Findings

Reviewing the diff fresh — 3 files changed: github/client.go (+78/-6),…

rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 18:58:27 +00:00
4c032a3b53 fix: move AllowInsecureHTTPForTest to export_test.go, fix gofmt alignment