Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin commented on pull request rodin/review-bot#113 2026-05-13 18:57:05 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fix Plan against 64c9d551ba85f4b431989ae3c049a6876a65132e:

Finding 1 — MINOR: AllowInsecureHTTPForTest in production file

Problem: AllowInsecureHTTPForTest is defined in `github/cli…

rodin commented on pull request rodin/review-bot#113 2026-05-13 18:53:36 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Self-Review: PR #113

Self-review against 64c9d551ba85f4b431989ae3c049a6876a65132e

Phase 1: Independent Findings

Reviewing the diff as a stranger to the codebase. Changes touch `github/clie…

rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 18:44:33 +00:00
64c9d551ba fix: address review feedback — restore timer.Stop() and fix test spacing
rodin commented on pull request rodin/review-bot#113 2026-05-13 18:43:32 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fix Plan against db7b7e66bf055972647eead67b072b9c999cc214:

Findings Summary

rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 18:35:12 +00:00
db7b7e66bf fix: use case-insensitive HTTP scheme check and redact userinfo
rodin commented on pull request rodin/review-bot#113 2026-05-13 18:34:58 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Re: Finding #2 (ClientOption functional options) — PUSH BACK

The functional options pattern is appropriate here:

  1. We already have two options with distinct behaviors (AllowInsecureHTTP…
rodin commented on pull request rodin/review-bot#113 2026-05-13 18:32:56 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fix Plan against 023234312617dcc456f4b62a05989126c8693503:

Finding 1 — MAJOR (both bots): Case-sensitive HTTP scheme check

Decision: FIX

The doRequest guard uses `strings.HasPrefix(…

rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 18:24:17 +00:00
0232343126 feat(github): add safeguards against accidental AllowInsecureHTTP use in production
b26514714f Merge pull request 'feat(gitea): pass commit_id explicitly in PostReview (#107)' (#112) from review-bot-issue-107 into main
028d46942a fix(gitea): update PostReview doc comment to include COMMENT event value
e59c2bc831 feat(gitea): pass commit_id explicitly in PostReview (#107)
Compare 4 commits »
rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 18:20:15 +00:00
2647da385e fix(github): address sonnet review feedback on PR #113
rodin commented on pull request rodin/review-bot#113 2026-05-13 18:18:35 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fix Plan against 06b92a68348a8f3341552c7beee1ca9afb3d01e8:

Sonnet Review 3358 Findings

rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 18:10:02 +00:00
06b92a6834 address review feedback: rename to With* convention, extract env const, redact query params, fix misleading test
rodin commented on pull request rodin/review-bot#113 2026-05-13 18:07:56 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fix Plan against 91f31ff2d7603d3f09fbd5e1492a37829394cd77

Findings Analysis

rodin commented on pull request rodin/review-bot#112 2026-05-13 17:51:23 +00:00
feat(gitea): pass commit_id explicitly in PostReview (#107)

Self-Review: PR #112

Self-review against 028d46942af0c605d1057510455ac4de38af31d2

Phase 1: Independent Findings

None — diff looks clean. The commitID string parameter is correctly…

rodin pushed to review-bot-issue-96 at rodin/review-bot 2026-05-13 17:48:20 +00:00
91f31ff2d7 address review feedback: export_test.go for AllowInsecureHTTPForTest, avoid url.Parse in doRequest
rodin commented on pull request rodin/review-bot#113 2026-05-13 17:46:42 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

Fix Plan against ce48dc0ec64e5ddbc0243bce590357b734e221ab:

MINOR #1 — AllowInsecureHTTPForTest exported API surface (client.go:116)

Action: FIX — Use the export_test.go pattern to…

rodin commented on pull request rodin/review-bot#112 2026-05-13 17:42:04 +00:00
feat(gitea): pass commit_id explicitly in PostReview (#107)

Fixed in 028d469: updated the doc comment to list all three valid event values: APPROVED, REQUEST_CHANGES, and COMMENT.

rodin pushed to review-bot-issue-107 at rodin/review-bot 2026-05-13 17:41:57 +00:00
028d46942a fix(gitea): update PostReview doc comment to include COMMENT event value
rodin commented on pull request rodin/review-bot#112 2026-05-13 17:41:25 +00:00
feat(gitea): pass commit_id explicitly in PostReview (#107)

Fix Plan against e59c2bc83162b38c48abfe8789434f68bbb08524:

Finding 1: NIT — PostReview doc comment inaccuracy (comment id 19793)

Source: sonnet-review-bot inline comment on…

rodin commented on pull request rodin/review-bot#112 2026-05-13 17:36:38 +00:00
feat(gitea): pass commit_id explicitly in PostReview (#107)

Self-Review: PR #112

Self-review against e59c2bc83162b38c48abfe8789434f68bbb08524

Phase 1: Independent Findings

None — diff looks clean. The commitID parameter is correctly threaded…

rodin created pull request rodin/review-bot#113 2026-05-13 17:31:37 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)