Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin pushed to review-bot-issue-115 at rodin/review-bot 2026-05-13 21:29:29 +00:00
7b47327cac fix(gitea): clarify per-comment CommitID forwarding comment
rodin commented on pull request rodin/review-bot#118 2026-05-13 21:28:40 +00:00
feat(vcs): add CommitID to ReviewRequest (#115)

Fix Plan against ce7a900737dbf36958ebf7b800eaf68b5c0a32d9

Findings to address

  1. [NIT] Comment 20287 — vcs/types.go CommitID alignment
    • Problem: sonnet flags possible gofmt…
rodin pushed to review-bot-issue-115 at rodin/review-bot 2026-05-13 21:23:52 +00:00
ce7a900737 fix(vcs): address self-review NITs - gofmt alignment and comment clarity
rodin commented on pull request rodin/review-bot#118 2026-05-13 21:23:04 +00:00
feat(vcs): add CommitID to ReviewRequest (#115)

Fix Plan against b9a07945d7cdca15bd2ebc60a0b57b98d687dc5b:

Findings to address

  1. [NIT] vcs/types.go — gofmt alignment padding
    • Problem: Event and CommitID fields have…
rodin commented on pull request rodin/review-bot#118 2026-05-13 21:19:56 +00:00
feat(vcs): add CommitID to ReviewRequest (#115)

Self-Review: PR #118

Self-review against b9a07945d7cdca15bd2ebc60a0b57b98d687dc5b

Phase 1: Independent Findings

  1. [NIT] vcs/types.go: The Event and CommitID fields use extra…
rodin pushed to review-bot-issue-115 at rodin/review-bot 2026-05-13 21:14:13 +00:00
b9a07945d7 fix(test): add missing blank line between test functions in adapter_test.go
rodin commented on pull request rodin/review-bot#118 2026-05-13 21:13:39 +00:00
feat(vcs): add CommitID to ReviewRequest (#115)

Fix Plan against c0c5226934efcf720d51902b560cf382819fdad7:

Finding

[NIT] gitea/adapter_test.go: Missing blank line between TestAdapter_PostReview_CommitID and `TestAdapter_PostRevie…

rodin commented on pull request rodin/review-bot#118 2026-05-13 21:10:17 +00:00
feat(vcs): add CommitID to ReviewRequest (#115)

Self-Review: PR #118

Self-review against c0c5226934efcf720d51902b560cf382819fdad7

Phase 1: Independent Findings

  1. [NIT] gitea/adapter_test.go: Missing blank line between `TestAdapte…
rodin pushed to review-bot-issue-115 at rodin/review-bot 2026-05-13 21:03:37 +00:00
c0c5226934 style: remove double blank lines in test files
rodin commented on pull request rodin/review-bot#118 2026-05-13 21:02:58 +00:00
feat(vcs): add CommitID to ReviewRequest (#115)

Fix Plan against 6d082367738e775e286e531f98ef39fa21f37346:

Finding: Double blank lines in test files

Files affected:

  • gitea/adapter_test.go — double blank line before `TestAdapter_…
rodin commented on pull request rodin/review-bot#117 2026-05-13 20:54:34 +00:00
fix(vcs): thread CommitID through abstraction layer (#114)

Self-Review: PR #117

Self-review against 25cb55449e5ee975d0eca9c642d238d6b42a41bc

Phase 1: Independent Findings

None — diff looks clean.

The implementation correctly threads…

rodin pushed to review-bot-issue-114 at rodin/review-bot 2026-05-13 20:49:46 +00:00
25cb55449e fix(nit): align CommitID field in vcs/types.go and document no-op in github/review.go
rodin commented on pull request rodin/review-bot#117 2026-05-13 20:47:53 +00:00
fix(vcs): thread CommitID through abstraction layer (#114)

Fix Plan against 7e3b6ec8f1c73fcad9c3c400c05ad96cd71b46c6:

Findings to address:

  1. [NIT] vcs/types.go line 99 — CommitID field alignment
    • Problem: CommitID string has…
rodin commented on pull request rodin/review-bot#118 2026-05-13 20:44:16 +00:00
feat(vcs): add CommitID to ReviewRequest (#115)

Self-Review: PR #118

Self-review against 6d082367738e775e286e531f98ef39fa21f37346

Phase 1: Independent Findings

None — diff looks clean. The implementation correctly:

  • Adds CommitID…
rodin commented on pull request rodin/review-bot#117 2026-05-13 20:38:47 +00:00
fix(vcs): thread CommitID through abstraction layer (#114)

Self-Review: PR #117

Self-review against 7e3b6ec8f1c73fcad9c3c400c05ad96cd71b46c6

Phase 1: Independent Findings

  1. [NIT] vcs/types.go line 99 — CommitID string field has…
rodin created pull request rodin/review-bot#118 2026-05-13 20:36:13 +00:00
feat(vcs): add CommitID to ReviewRequest (#115)
rodin pushed to review-bot-issue-115 at rodin/review-bot 2026-05-13 20:36:03 +00:00
6d08236773 feat(vcs): add CommitID to ReviewRequest (#115)
rodin created branch review-bot-issue-115 in rodin/review-bot 2026-05-13 20:36:03 +00:00
rodin commented on issue rodin/review-bot#115 2026-05-13 20:31:19 +00:00
PR #112: vcs.ReviewRequest.CommitID field missing — issue #107's interface-level fix not implemented

Plan: Add CommitID to vcs.ReviewRequest (#115)

Problem

PR #112 refactored the review path to use the vcs.ReviewRequest abstraction, but removed the commitID parameter from `gitea.Clien…

rodin created pull request rodin/review-bot#117 2026-05-13 20:31:06 +00:00
fix(vcs): thread CommitID through abstraction layer (#114)