Rodin

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:53 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Inline Comment Resolution Summary

All inline review findings on PR #118 have been addressed. The code at HEAD (7b47327) is correct. Summary of each thread:

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:44 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20298 (vcs/types.go — extra whitespace padding on CommitID before json tag)

Fixed in commit ce7a900 (fix(vcs): address self-review NITs). Running gofmt -w vcs/types.go…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:44 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20288 (gitea/adapter.go — misleading comment on CommitID forwarding)

Fixed in commit 7b47327 (fix(gitea): clarify per-comment CommitID forwarding comment). Updated…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:43 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20287 (vcs/types.go — CommitID struct field alignment inconsistency)

Fixed in commit ce7a900. Confirmed in issue comment #20297: gofmt -l vcs/types.go returns empty —…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:43 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20275 (github/review.go — conflict detection comment readability)

Fixed in commit ce7a900 (fix(vcs): address self-review NITs). A clarifying comment was added to the…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:42 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20260 (gitea/adapter_test.go — missing blank line between test functions)

Fixed in commit b9a0794 (fix(test): add missing blank line between test functions in adapter_test…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:42 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20274 (vcs/types.go — inconsistent struct field alignment)

Fixed in commit ce7a900 (fix(vcs): address self-review NITs). gofmt normalization resolved the tab-vs-spaces…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:41 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20259 (vcs/types.go — trailing whitespace padding on Event/CommitID fields)

Fixed in commit ce7a900 (fix(vcs): address self-review NITs). Running gofmt -w vcs/types.go…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:41 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20201 (vcs/types.go — alignment inconsistency in ReviewRequest struct)

Fixed in commit ce7a900 (fix(vcs): address self-review NITs - gofmt alignment and comment clarity).…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:40 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Re: inline comment #20200 (gitea/adapter_test.go — double blank line between test functions)

Fixed in commit c0c5226 (style: remove double blank lines in test files). The extra blank line…

rodin commented on pull request rodin/review-bot#118

2026-05-13 22:45:22 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Fix Plan against 7b47327cac0a7151ccc2b237fb633910bfbb38ac:

This plan documents replies for all unresolved inline review comment threads on PR #118. The code is already correct — all findings…

rodin created pull request rodin/review-bot#119

2026-05-13 22:36:11 +00:00

fix(github): consolidate review.go and identity.go into reviews.go (#116)

rodin pushed to review-bot-issue-116 at rodin/review-bot

2026-05-13 22:36:00 +00:00

bf02733507 fix(github): consolidate review.go and identity.go into reviews.go (#116)

rodin created branch review-bot-issue-116 in rodin/review-bot

2026-05-13 22:36:00 +00:00

rodin commented on pull request rodin/review-bot#117

2026-05-13 22:34:21 +00:00

fix(vcs): thread CommitID through abstraction layer (#114)

Self-Review: PR #117

Self-review against 25cb55449e5ee975d0eca9c642d238d6b42a41bc

Phase 1: Independent Findings

None — diff looks clean.

The implementation correctly threads…

rodin commented on issue rodin/review-bot#116

2026-05-13 22:29:49 +00:00

Build broken: github/reviews.go duplicates github/review.go — redeclared types and methods

Plan: Fix build — remove duplicate github/review.go

Problem

github/review.go and github/reviews.go both declare the same types (reviewResponse, dismissReviewRequest) and methods…

rodin commented on pull request rodin/review-bot#117

2026-05-13 22:04:15 +00:00

fix(vcs): thread CommitID through abstraction layer (#114)

Inline comment 20187 (vcs/types.go alignment NIT): Addressed in 25cb554 — alignment cleaned up to match adjacent fields. Inline comment 20240 (github/review.go comment style NIT): Flagged invalid…

rodin commented on pull request rodin/review-bot#117

2026-05-13 21:44:00 +00:00

fix(vcs): thread CommitID through abstraction layer (#114)

Self-Review: PR #117

Self-review against 25cb55449e5ee975d0eca9c642d238d6b42a41bc

Phase 1: Independent Findings

None — diff looks clean.

The implementation correctly threads…

rodin commented on pull request rodin/review-bot#118

2026-05-13 21:34:01 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

Self-Review: PR #118

Self-review against 7b47327cac0a7151ccc2b237fb633910bfbb38ac

Phase 1: Independent Findings

None — diff looks clean. The implementation correctly:

Adds CommitID…

rodin commented on pull request rodin/review-bot#118

2026-05-13 21:29:46 +00:00

feat(vcs): add CommitID to ReviewRequest (#115)

✅ Both NITs addressed in 7b47327:

Comment 20287 (vcs/types.go alignment): Confirmed gofmt -l returns empty — file is already properly formatted.
Comment 20288 (gitea/adapter.go…