Re: comment #20533 — Fixed. Reordered stdlib imports in github/review_test.go to alphabetical per goimports convention:…
Fix Plan against 8e26c26f5fffa5d004058b04500b777bc7877ec3:
Finding #20533 — [NIT] Import ordering in github/review_test.go
Decision: FIX
The import block currently has fmt before…
Self-Review: PR #119
Self-review against 8e26c26f5fffa5d004058b04500b777bc7877ec3
Phase 1: Independent Findings
F1 [NIT] github/review_test.go line 5 — Import ordering
"fmt"…
Re: inline NIT on gitea/client_test.go — Acknowledged. This is a valid style observation (io.ReadAll + json.Unmarshal…
Acknowledged — this is a valid style observation. TestPostReview_CommitID uses io.ReadAll + json.Unmarshal while neighboring tests use json.NewDecoder. The inconsistency has zero correctness impact. Per the self-review (comment #20304), this was explicitly noted as "Not worth a fix iteration" — the test is new code added by this PR and introducing another fix commit just to change the decode pattern would be churn with no functional benefit. Declining to fix; leaving as-is.
Acknowledged — this is a valid style observation. TestPostReview_CommitID uses io.ReadAll + json.Unmarshal while neighboring tests use json.NewDecoder. The inconsistency has zero correctness impact. Per the self-review (comment #20304), this was explicitly noted as "Not worth a fix iteration" — the test is new code added by this PR and introducing another fix commit just to change the decode pattern would be churn with no functional benefit. Declining to fix; leaving as-is.
Acknowledged — this is a valid style observation. TestPostReview_CommitID uses io.ReadAll + json.Unmarshal while neighboring tests use json.NewDecoder. The inconsistency has zero correctness impact. Per the self-review (comment #20304), this was explicitly noted as "Not worth a fix iteration" — the test is new code added by this PR and introducing another fix commit just to change the decode pattern would be churn with no functional benefit. Declining to fix; leaving as-is.
Fix Plan against 9a6298cc4feae2c6f4c795028d561370a7c59357:
Finding: [NIT] TestPostReview_CommitID decode pattern inconsistency (inline comment #20478)
Action: PUSH BACK / DECLINE
The…
Self-Review: PR #118
Self-review against 9a6298cc4feae2c6f4c795028d561370a7c59357
Phase 1: Independent Findings
- [NIT]
gitea/client_test.goline ~147:TestPostReview_CommitID…
b2c83c00bc
Merge pull request 'fix(vcs): thread CommitID through abstraction layer (#114)' (#117) from review-bot-issue-114 into feature/github-support
All three review NITs addressed in 9a6298c:
- vcs/types.go (#20447): Restored blank line between
CommitIDandCommentsfor visual grouping. - gitea/adapter_test.go (#20448): Merged…
Fix Plan against be68e518980d7c66637d0d1354ee3dff3bad66d7:
All three findings are NITs. Addressing all three:
1. vcs/types.go — Restore blank line in ReviewRequest (NIT #20447)
**Action:*…
b2c83c00bc
Merge pull request 'fix(vcs): thread CommitID through abstraction layer (#114)' (#117) from review-bot-issue-114 into feature/github-support
Self-Review: PR #119
Self-review against 86beba63dac63bf43a986e52c545d4e5535f9998
Phase 1: Independent Findings
F1 [NIT] github/review_test.go line 5 — Import ordering
"fmt"…
Fix Plan against bf027335074c1617d1adef0ab1c838cfd763c0b1
Findings to Address
F1 [MINOR] No pagination tests for ListReviews
Add comprehensive pagination tests to review_test.go: 1.…
Self-Review: PR #119
Self-review against bf027335074c1617d1adef0ab1c838cfd763c0b1
Phase 1: Independent Findings
F1 [MINOR] github/reviews.go — No pagination tests for ListReviews
…