Rodin

rodin commented on pull request rodin/review-bot#121

2026-05-14 04:13:07 +00:00

fix(action): detect VCS host type for version resolution and binary download

Review Feedback Addressed (646497d)

All findings from the three reviews have been addressed:

gpt MAJOR #1 + sonnet MINOR #1: GitHub API URL

Fixed. Now uses ${{ github.api_url }}…

rodin pushed to review-bot-issue-120 at rodin/review-bot

2026-05-14 04:12:36 +00:00

646497de68 fix(action): address review feedback on VCS host detection and API URL

rodin commented on pull request rodin/review-bot#122

2026-05-14 04:11:51 +00:00

fix(#120): detect VCS host for releases API and derive action-repo

Closing as duplicate of #121, which targets main directly with the same fix.

rodin closed pull request rodin/review-bot#122

2026-05-14 04:11:47 +00:00

fix(#120): detect VCS host for releases API and derive action-repo

rodin commented on pull request rodin/review-bot#121

2026-05-14 04:11:04 +00:00

fix(action): detect VCS host type for version resolution and binary download

Fix Plan against d4d34aa029dc819f2a42725e6a0104ba24a1c9b2:

Findings Summary & Approach

MAJOR Findings

rodin pushed to issue-120 at rodin/review-bot

2026-05-14 04:07:04 +00:00

db13078196 chore: use dry-run in review.yml (GHE has no releases yet, validate infra)

rodin created pull request rodin/review-bot#122

2026-05-14 04:04:14 +00:00

fix(#120): detect VCS host for releases API and derive action-repo

rodin pushed to issue-120 at rodin/review-bot

2026-05-14 04:04:01 +00:00

3ac5e5dcca fix(#120): detect VCS host for releases API and derive action-repo

rodin created branch issue-120 in rodin/review-bot

2026-05-14 04:04:01 +00:00

rodin created pull request rodin/review-bot#121

2026-05-14 04:02:22 +00:00

fix(action): detect VCS host type for version resolution and binary download

rodin pushed to review-bot-issue-120 at rodin/review-bot

2026-05-14 04:02:10 +00:00

d4d34aa029 fix(action): detect VCS host type for version resolution and binary download

rodin created branch review-bot-issue-120 in rodin/review-bot

2026-05-14 04:02:10 +00:00

rodin commented on issue rodin/review-bot#120

2026-05-14 04:00:47 +00:00

action: version resolution and binary download fail when running on GitHub

Plan: Fix version resolution and binary download for GitHub hosts

Problem

The composite action in both .gitea/actions/review/action.yml and .github/actions/review/action.yml has three…

rodin opened issue rodin/review-bot#120

2026-05-14 03:58:44 +00:00

action: version resolution and binary download fail when running on GitHub

rodin commented on pull request rodin/review-bot#119

2026-05-14 01:08:14 +00:00

fix(github): consolidate review.go and identity.go into reviews.go (#116)

Self-Review: PR #119

Self-review against 437e318240a0579f62ba567a3e33e469d0abe926

Phase 1: Independent Findings

None — diff looks clean.

Reasoning: The diff is a focused consolidatio…

rodin commented on pull request rodin/review-bot#119

2026-05-14 01:02:13 +00:00

fix(github): consolidate review.go and identity.go into reviews.go (#116)

Re: inline comment #20634 — FIX ✅

Good catch. The existing comment was decent but I agree it could be more explicit.…

rodin commented on pull request rodin/review-bot#119

2026-05-14 01:02:13 +00:00

fix(github): consolidate review.go and identity.go into reviews.go (#116)

Re: inline comment #20635 — PUSH BACK 🙅

Intentional consolidation per the issue scope. GetAuthenticatedUser is…

rodin pushed to review-bot-issue-116 at rodin/review-bot

2026-05-14 01:02:02 +00:00

437e318240 nit: clarify truncation detection comment in ListReviews

rodin commented on pull request rodin/review-bot#119

2026-05-14 01:01:16 +00:00

fix(github): consolidate review.go and identity.go into reviews.go (#116)

Fix Plan against 2e2fcbabfc0442bc421d4a3af1102465fa30f54c:

Comment 20634 — truncation check clarity (NIT) → FIX

The existing inline comment already explains the intent reasonably well,…

rodin commented on pull request rodin/review-bot#119

2026-05-14 00:53:52 +00:00

fix(github): consolidate review.go and identity.go into reviews.go (#116)

Re: comment #20534 — Fixed. Restored the explanatory comment `// nil body: the GitHub DELETE endpoint for reviews requires…