This website requires JavaScript.
49d6ca77a3
refactor(gitea): eliminate retry duplication, harden redactURL and MaxInt64 edge case
2026-05-13 05:40:49 -07:00
6ebf66aefb
fix(gitea): address review feedback on diff size limiting
2026-05-13 05:23:42 -07:00
004343d05f
fix(gitea): address review findings — clamp overflow, clarify maxSize doc
2026-05-13 05:17:14 -07:00
92b84976cf
feat(gitea): harden GetPullRequestDiff against unbounded diff size
2026-05-13 04:57:30 -07:00
4e8c676515
Merge pull request 'feat(github): implement Reviewer and Identity interfaces (#81 )' (#105 ) from review-bot-issue-81 into feature/github-support
aweiker
2026-05-13 13:39:13 +00:00
9f8e9aa8d3
fix: timer leak and http field shadowing in github client
2026-05-13 06:22:30 -07:00
027bad2f7c
fix(github): add DismissReview Event comment; use t.Fatalf for routing assertions
2026-05-13 03:06:00 -07:00
cd8a1becb3
test(github): use t.Run subtests in TestTranslateGitHubReviewState; doc: note nil body in DeleteReview
2026-05-13 02:04:06 -07:00
9dd5e8dbac
fix(github): validate conflicting commit IDs and extract test helper
2026-05-13 01:44:11 -07:00
8b256360bf
fix(github): clarify PostReview doc comment, rename test field to 'want'
2026-05-13 01:29:14 -07:00
293296b50c
address review feedback: wrap ErrCannotDeleteSubmittedReview, fix nits
2026-05-13 00:54:21 -07:00
eba97321ad
refactor(github): extract doRequestCore, address review feedback
2026-05-13 00:35:59 -07:00
be3f696a70
feat(github): implement Reviewer and Identity interfaces (#81 )
2026-05-13 00:25:50 -07:00
881ce232eb
Merge pull request 'docs(deps): update CONVENTIONS.md allowlist for go-yaml' (#108 ) from review-bot-issue-91 into main
aweiker
2026-05-13 13:16:40 +00:00
65ba8af244
Merge pull request 'fix(gitea): map hunk-header positions in BuildPositionToLineMap' (#104 ) from review-bot-issue-97 into feature/github-support
aweiker
2026-05-13 13:15:30 +00:00
31a28b1dd5
address review feedback: baseURL TODO, timer-cancel test, fast retry test, doc note
2026-05-13 06:08:51 -07:00
e414471a16
fix(github): address review feedback on Retry-After implementation
2026-05-13 05:54:06 -07:00
41e1d48b54
feat(github): support HTTP-date format in Retry-After header
2026-05-13 05:10:52 -07:00
bf52fceea0
docs(deps): update CONVENTIONS.md allowlist for go-yaml
2026-05-13 02:56:06 -07:00
02bdd701a5
test(gitea): add hunk-header-at-end error path test
2026-05-12 23:32:22 -07:00
23dc781908
fix(gitea): map hunk-header positions in BuildPositionToLineMap
2026-05-12 23:13:28 -07:00
1960d987ed
Merge pull request 'feat(github): implement FileReader interface' (#103 ) from issue-80-c-file-reader into feature/github-support
aweiker
2026-05-13 06:05:58 +00:00
dca260f582
fix(test): SetRetryBackoff with correct slice length
2026-05-12 22:47:31 -07:00
921599542d
feat(github): implement FileReader interface (#80 )
aweiker
2026-05-13 04:13:00 +00:00
71bb33b6fd
Merge pull request 'feat(github): implement PRReader interface' (#102 ) from issue-80-b-pr-reader into feature/github-support
aweiker
2026-05-13 05:30:37 +00:00
55366b3431
fix: address review feedback on PRReader implementation
2026-05-12 22:17:32 -07:00
3cd5ae594e
fix(github): escapePath returns error on dot-segments, fix Description semantics
2026-05-12 22:03:52 -07:00
eaccc96073
fix: address review feedback on PR #102
2026-05-12 21:36:45 -07:00
289b400bfd
fix(github): add GetFileContentAtRef and fix conformance test
2026-05-12 21:21:01 -07:00
d0b7f09772
feat(github): implement PRReader interface (#80 )
aweiker
2026-05-13 04:12:13 +00:00
377da8ca3a
Merge pull request 'feat(github): implement GitHub API client foundation' (#101 ) from issue-80-a-client into feature/github-support
aweiker
2026-05-13 04:46:46 +00:00
61819ac3e3
fix(github): address review findings - remove panic, validate at config time
2026-05-12 21:31:45 -07:00
3d1260d3b2
fix(github): clarify response ownership and validate backoff length
2026-05-12 21:26:39 -07:00
6316007eb1
fix: address review findings from reviews #2955 and #2958
2026-05-12 21:19:01 -07:00
0e7e12a99c
feat(github): implement GitHub API client foundation (#80 )
aweiker
2026-05-13 04:11:53 +00:00
b380e7fcae
refactor(github): extract handleResponse for safe defer body close
2026-05-12 20:47:59 -07:00
d722035629
Merge pull request 'fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml' (#89 ) from review-bot-issue-87 into main
aweiker
2026-05-13 03:47:01 +00:00
30798ff023
fix: address sonnet review MINOR findings (#2916 )
2026-05-12 20:28:52 -07:00
6e8e744816
fix(github): address self-review findings from 1194bc75
2026-05-12 19:40:30 -07:00
1194bc758c
fix(github): address review findings from rounds 2884/2885/2887
2026-05-12 19:29:06 -07:00
b9b7be3b4e
fix: address review #2888 findings (comment clarity, test cleanup)
2026-05-12 19:06:52 -07:00
baa917f228
fix: handle MergeKeyNode explicitly in depth check, add size limit to ParsePersonaBytes
2026-05-12 18:45:48 -07:00
80af5037b2
fix(github): address review findings from round 2880/2883
2026-05-12 18:41:44 -07:00
5b2fa0b9af
refactor(github): address review findings from round 2872
2026-05-12 18:16:43 -07:00
b0352ba1c9
docs: address review findings on YAML depth validation
2026-05-12 17:39:38 -07:00
491df7cb1f
fix(github): address review findings from rounds 2867/2870
2026-05-12 17:30:24 -07:00
1862dc999d
Merge pull request 'feat(vcs): Gitea adapter with diff-position translation (Phase 2)' (#90 ) from review-bot-issue-79 into feature/github-support
aweiker
2026-05-13 00:18:05 +00:00
1fcc0b738a
fix(github): address MINOR/NIT findings from review #2866
2026-05-12 17:13:07 -07:00
fce5f2d184
fix(github): address review findings on client.go
2026-05-12 16:55:32 -07:00
af72c64b7f
fix(github): correct ListContents error wrapping and move HTTPS guard before retry loop
2026-05-12 16:48:39 -07:00
1bc3f206ba
fix: address review findings from rounds 2843-2846
2026-05-12 16:39:01 -07:00
c10bb72117
fix: address self-review NIT findings on PR #93
2026-05-12 16:25:32 -07:00
ae91c8aef5
fix: address review findings from rounds 2834-2838
2026-05-12 16:11:58 -07:00
75f65fbf5d
fix: address MINOR review findings on PR #93 (round 2)
2026-05-12 16:00:09 -07:00
5b43afc6d4
fix: address review feedback on PR #93
2026-05-12 15:43:45 -07:00
0b16c4143a
test: use per-subtest TempDir in TestYAMLEmptyFileRejection
2026-05-12 15:22:27 -07:00
d1ef1e21e5
feat(github): implement PRReader + FileReader client (#80 )
2026-05-12 15:16:33 -07:00
d8270262d6
Wrap errors in GetPullRequest and PostReview for consistency
2026-05-12 14:56:55 -07:00
493349e11a
fix: correct comment accuracy and improve trailing-content check clarity
2026-05-12 14:51:49 -07:00
5cedeee9f4
address self-review findings on PR #89
2026-05-12 14:42:22 -07:00
01b6af03a8
fix(review): address review 2792 feedback
2026-05-12 14:24:06 -07:00
80091fb080
fix(review): address feedback from reviews 2788, 2789, 2791
2026-05-12 14:13:59 -07:00
b5f17ddfc4
fix(security): prevent alias depth bypass in YAML validator
2026-05-12 14:05:13 -07:00
b2eea502d0
refactor(gitea): address review feedback on PR #90
2026-05-12 13:57:44 -07:00
144a36a2a7
docs: update DESIGN-57 to reflect goccy/go-yaml as the supported YAML library
rodin
2026-05-12 20:52:37 +00:00
12f5f5a5e4
docs: update YAML library to github.com/goccy/go-yaml in CONVENTIONS.md
rodin
2026-05-12 20:52:31 +00:00
0ec5093aeb
fix: address self-review findings on PR #90
2026-05-12 13:49:36 -07:00
45d009dd06
fix(review): address review feedback on persona YAML handling
2026-05-12 13:38:48 -07:00
8a0eed298a
feat(vcs): Gitea adapter with diff-position translation
2026-05-12 13:30:26 -07:00
8991260333
fix(deps): replace gopkg.in/yaml.v3 with github.com/goccy/go-yaml
2026-05-12 13:27:30 -07:00
8e4c1cc32e
Merge pull request 'feat(vcs): complete Phase 1 — util.go, type cleanup, interface additions (fixes #84 , #85 , #86 )' (#88 ) from review-bot-issue-84 into feature/github-support
aweiker
2026-05-12 20:18:18 +00:00
ec03dc2373
fix: address remaining review findings (interface assertions, DismissReview ctx, import order, filepath param, spelling)
2026-05-12 13:07:41 -07:00
1749d95727
fix(vcs): address review findings on PR #88
2026-05-12 12:56:13 -07:00
7c83365fc4
feat(vcs): complete Phase 1 — util.go, type cleanup, interface additions (fixes #84 , #85 , #86 )
2026-05-12 12:38:21 -07:00
6be5e306aa
Merge pull request 'feat(vcs): extract interfaces and types from gitea/ (Phase 1)' (#83 ) from review-bot-issue-78 into feature/github-support
aweiker
2026-05-12 19:14:45 +00:00
cd6cd93bf0
fix(vcs): address PR #83 review findings (round 2)
2026-05-12 12:06:29 -07:00
c889724dda
fix(vcs): address Phase 1 review findings
2026-05-12 12:00:30 -07:00
1ac51669ed
docs(vcs): add package doc to interfaces.go
2026-05-12 10:05:39 -07:00
2e6f46f28d
feat(vcs): extract interfaces and types from gitea/ (Phase 1, #78 )
2026-05-12 10:04:57 -07:00
6f86e66943
fix(patterns): default patterns-files to empty (fetch all) (#77 )
rodin
2026-05-11 17:45:19 +00:00
3fc31c0822
docs: flip design — extract interfaces from working gitea/ code
2026-05-11 10:11:13 -07:00
2b611dbd0b
docs: rewrite design doc — feature-first, testable, phased
2026-05-11 09:43:51 -07:00
3abb611baf
docs: add VCS abstraction design doc
2026-05-11 09:30:43 -07:00
dd003c66d5
feat: add GitHub Actions support
2026-05-11 08:42:33 -07:00
019b815280
Merge pull request 'fix(gitea): handle single-object response in ListContents' (#74 ) from issue-73 into main
aweiker
2026-05-11 15:38:59 +00:00
c27dfd0f08
fix(gitea): guard against empty response in ListContents fallback
2026-05-11 07:47:03 -07:00
1b6c37605f
fix(gitea): handle single-object response in ListContents
2026-05-11 07:21:15 -07:00
036e96d9b7
Merge pull request 'fix(gitea): normalize "." path to empty string in ListContents' (#72 ) from issue-70 into main
aweiker
2026-05-11 14:16:22 +00:00
ea74f7e088
ci: use rodin/security-patterns with '.' path for security reviewer
2026-05-11 07:12:25 -07:00
e6b1840ffc
fix(gitea): normalize "." path to empty string in ListContents
2026-05-11 06:24:05 -07:00
1ca9250e4a
Merge pull request 'feat(gitea): add retry logic for 5xx errors' (#69 ) from issue-68 into main
aweiker
2026-05-11 12:59:50 +00:00
1b38e6ad00
fix(gitea): ensure consistent lastErr return for network errors
2026-05-11 05:31:39 -07:00
5498dccd60
fix(gitea): address MINOR review findings on retry logic
2026-05-11 05:15:07 -07:00
ecfbfddc7c
fix(gitea): redact query params from retry warning logs
2026-05-11 04:52:41 -07:00
ac53ecfa5d
fix(gitea): improve retry logic precision for net.OpError
2026-05-11 04:32:15 -07:00
090ae3848c
fix(gitea): make retry backoff configurable and retry temp net errors
2026-05-11 04:23:27 -07:00
23da7eedf5
fix(gitea): address review feedback on retry logic
2026-05-11 01:08:01 -07:00
7279cdd216
feat(gitea): add retry logic for 5xx errors in doGet
2026-05-11 00:59:47 -07:00
4c327b61d4
Merge pull request 'feat: log loaded pattern files for debugging' (#65 ) from issue-64 into main
aweiker
2026-05-11 06:53:00 +00:00
877dbf9999
Merge pull request 'docs: add read:user to required token scopes' (#67 ) from issue-66 into main
aweiker
2026-05-11 06:52:21 +00:00
claw
aweiker
rodin
Rodin
Aaron Weiker