test(github): use t.Run subtests in TestTranslateGitHubReviewState; doc: note nil body in DeleteReview
This commit is contained in:
@@ -173,6 +173,7 @@ func (c *Client) DeleteReview(ctx context.Context, owner, repo string, number in
|
||||
reqURL := fmt.Sprintf("%s/repos/%s/%s/pulls/%d/reviews/%d",
|
||||
c.baseURL, url.PathEscape(owner), url.PathEscape(repo), number, reviewID)
|
||||
|
||||
// nil body: the GitHub DELETE endpoint for reviews requires no request body.
|
||||
_, err := c.doRequestWithBody(ctx, http.MethodDelete, reqURL, nil)
|
||||
if err != nil {
|
||||
var apiErr *APIError
|
||||
|
||||
+13
-10
@@ -348,21 +348,24 @@ func TestDismissReview_401(t *testing.T) {
|
||||
|
||||
func TestTranslateGitHubReviewState(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
input string
|
||||
want string
|
||||
}{
|
||||
{"APPROVED", "APPROVED"},
|
||||
{"CHANGES_REQUESTED", "REQUEST_CHANGES"},
|
||||
{"COMMENTED", "COMMENT"},
|
||||
{"DISMISSED", "DISMISSED"},
|
||||
{"UNKNOWN_STATE", "UNKNOWN_STATE"},
|
||||
{"", ""},
|
||||
{"approved passes through", "APPROVED", "APPROVED"},
|
||||
{"changes_requested maps to REQUEST_CHANGES", "CHANGES_REQUESTED", "REQUEST_CHANGES"},
|
||||
{"commented maps to COMMENT", "COMMENTED", "COMMENT"},
|
||||
{"dismissed passes through", "DISMISSED", "DISMISSED"},
|
||||
{"unknown state passes through", "UNKNOWN_STATE", "UNKNOWN_STATE"},
|
||||
{"empty string passes through", "", ""},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
got := translateGitHubReviewState(tt.input)
|
||||
if got != tt.want {
|
||||
t.Errorf("translateGitHubReviewState(%q) = %q, want %q", tt.input, got, tt.want)
|
||||
}
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
got := translateGitHubReviewState(tt.input)
|
||||
if got != tt.want {
|
||||
t.Errorf("translateGitHubReviewState(%q) = %q, want %q", tt.input, got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user