Compare commits

...

2 Commits

Author SHA1 Message Date
Rodin 282b6e0e86 nit(#154): add t.Fatal guard if baseSubprocessArgs flag not found
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 17s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 22s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 38s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 40s
Address sonnet NIT: if --repo or --pr is ever removed from
baseSubprocessArgs(), the mutation loop silently no-ops and the test
becomes meaningless. Adding a found guard and t.Fatal makes the
regression immediately visible.
2026-05-15 08:06:18 -07:00
Rodin 838a34aa12 chore: cycle status 2026-05-15 14:42
CI / test (push) Successful in 16s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (push) Has been skipped
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (push) Has been skipped
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (push) Has been skipped
2026-05-15 14:42:27 +00:00
2 changed files with 48 additions and 0 deletions
+38
View File
@@ -0,0 +1,38 @@
# Dev-Loop Cycle Status — 2026-05-15 14:42 UTC
**Cron ID:** 5342ac81-4bbc-4e4c-a123-347a7788d50c
**Cycle:** review-bot-dev-loop (4-hour schedule)
**Status:****STEADY STATE** — All systems nominal, repo healthy
## Health Check Summary
| Check | Status | Details |
|-------|--------|---------|
| Main branch | ✅ Current | HEAD at 8ab45be (synced) |
| Working tree | ✅ Clean | No uncommitted changes |
| Test suite | ✅ All pass | 100% pass rate (go test ./...) |
| Code coverage | ✅ 76.7% | Above baseline target |
| Open issues | ✅ None | No assigned work |
| Open PRs | ✅ None | All merged |
| Remote sync | ✅ On-time | Up-to-date with origin/main |
## Actions This Cycle
- ✅ Fetched origin/main — up-to-date
- ✅ Ran full test suite — all pass
- ✅ Calculated code coverage — 76.7%
- ✅ Checked for new issues/PRs — none found
- ✅ Verified working tree clean
## Backlog Opportunities
1. **Integration tests** — cmd/review-bot coverage (53.3% → target 80%)
2. **Performance profiling** — doc-map filtering optimization
3. **Documentation** — Composite action examples
## Recommendation
**No new assignments.** Repo ready for next feature work. Standing by.
---
Generated: 2026-05-15 14:42 UTC | Cron: review-bot-dev-loop
+10
View File
@@ -903,12 +903,17 @@ func TestMainSubprocess_InvalidRepo(t *testing.T) {
flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ExitOnError)
args := baseSubprocessArgs()
// Replace the canonical --repo value with an invalid one.
found := false
for i, a := range args {
if a == "--repo" && i+1 < len(args) {
args[i+1] = "invalidrepo"
found = true
break
}
}
if !found {
t.Fatal("baseSubprocessArgs() does not contain --repo; test is broken")
}
os.Args = args
main()
return
@@ -930,12 +935,17 @@ func TestMainSubprocess_InvalidPRNumber(t *testing.T) {
flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ExitOnError)
args := baseSubprocessArgs()
// Replace the canonical --pr value with a non-numeric string.
found := false
for i, a := range args {
if a == "--pr" && i+1 < len(args) {
args[i+1] = "notanumber"
found = true
break
}
}
if !found {
t.Fatal("baseSubprocessArgs() does not contain --pr; test is broken")
}
os.Args = args
main()
return