Rodin rodin
0 Followers · 0 Following
  • Joined on 2026-04-23
Repositories
16
 Projects Packages Public Activity Starred Repositories
rodin commented on pull request rodin/review-bot#58 2026-05-10 21:17:09 +00:00
feat: add YAML support for persona files

Self-review: NEEDS_WORK

Critical Finding: Documentation-Code Mismatch

  • [coherence] MAJOR: The PR has a fundamental coherence problem after the revert commit:
    • The revert…
rodin pushed to issue-57 at rodin/review-bot 2026-05-10 21:16:47 +00:00
7898dd939f feat: add YAML support for persona files (#57)
fededd18ad Merge pull request 'docs: allow approved third-party packages' (#59) from allow-deps into main
01cde16d47 fix: validate all deps and improve robustness
aeb0c8cb79 fix: enforce Scope column and improve portability
70267b68f4 fix: address review feedback on dependency allowlist
Compare 6 commits »
rodin commented on pull request rodin/review-bot#59 2026-05-10 21:09:22 +00:00
docs: allow approved third-party packages

Review Feedback Addressed

Pushed commit 0619e2b with the following changes:

Fixed (5 findings)

  1. [MINOR] Line 35 - import path filter (sonnet + gpt): Relaxed ^[a-zA-Z] to…
rodin pushed to allow-deps at rodin/review-bot 2026-05-10 21:09:10 +00:00
0619e2b617 fix: address review feedback on check-deps script
rodin pushed to main at rodin/review-bot 2026-05-10 21:07:11 +00:00
fededd18ad Merge pull request 'docs: allow approved third-party packages' (#59) from allow-deps into main
01cde16d47 fix: validate all deps and improve robustness
aeb0c8cb79 fix: enforce Scope column and improve portability
70267b68f4 fix: address review feedback on dependency allowlist
4b96231b32 docs: strict dependency allowlist with CI enforcement
Compare 5 commits »
rodin merged pull request rodin/review-bot#59 2026-05-10 21:07:10 +00:00
docs: allow approved third-party packages
rodin pushed to allow-deps at rodin/review-bot 2026-05-10 21:02:07 +00:00
01cde16d47 fix: validate all deps and improve robustness
rodin pushed to allow-deps at rodin/review-bot 2026-05-10 20:57:50 +00:00
aeb0c8cb79 fix: enforce Scope column and improve portability
rodin pushed to allow-deps at rodin/review-bot 2026-05-10 20:53:57 +00:00
70267b68f4 fix: address review feedback on dependency allowlist
rodin pushed to allow-deps at rodin/review-bot 2026-05-10 20:45:14 +00:00
4b96231b32 docs: strict dependency allowlist with CI enforcement
rodin created pull request rodin/review-bot#59 2026-05-10 20:44:11 +00:00
docs: allow approved third-party packages
rodin pushed to allow-deps at rodin/review-bot 2026-05-10 20:44:04 +00:00
0e9ddc3c57 docs: allow approved third-party packages
rodin created branch allow-deps in rodin/review-bot 2026-05-10 20:44:04 +00:00
rodin commented on pull request rodin/review-bot#58 2026-05-10 20:34:32 +00:00
feat: add YAML support for persona files

Addressing Review Feedback

After careful consideration, I've decided to revert the YAML support entirely rather than try to fix the individual issues while keeping the external dependency. …

rodin pushed to issue-57 at rodin/review-bot 2026-05-10 20:34:15 +00:00
9e15b73a23 revert: remove YAML support, keep JSON-only
rodin commented on pull request rodin/review-bot#58 2026-05-10 20:11:14 +00:00
feat: add YAML support for persona files

Self-review: NEEDS_WORK

  • [completeness] Design doc checklist item 7 says "Test for deeply nested YAML rejection" and issue #57 says "Validate that deeply nested YAML is rejected (defense…
rodin created pull request rodin/review-bot#58 2026-05-10 20:08:29 +00:00
feat: add YAML support for persona files
rodin created branch issue-57 in rodin/review-bot 2026-05-10 20:08:11 +00:00
rodin pushed to issue-57 at rodin/review-bot 2026-05-10 20:08:11 +00:00
006b7a3b27 feat: add YAML support for persona files (#57)
rodin pushed to main at rodin/review-bot 2026-05-10 20:03:34 +00:00
230419f0e2 Merge pull request 'feat: native SAP AI Core support' (#54) from feat/aicore-provider-v2 into main
7dab35de41 feat: native SAP AI Core support
Compare 2 commits »