Rodin

rodin created branch issue-60 in rodin/review-bot

2026-05-11 02:01:56 +00:00

rodin pushed to issue-60 at rodin/review-bot

2026-05-11 02:01:56 +00:00

c1c8e61e9d feat: load personas from target repo .review-bot/personas/

rodin opened issue rodin/review-bot#60

2026-05-11 01:57:13 +00:00

Load personas from target repo .review-bot/personas/

rodin pushed to main at rodin/model-research

2026-05-11 01:32:58 +00:00

0f43934cb8 Add finding #67: Inter-document contradiction analysis

rodin commented on pull request rodin/review-bot#58

2026-05-11 00:55:04 +00:00

feat: add YAML support for persona files

Self-review: PASS

No issues found — ready for human review.

Changes reviewed:

Symlink documentation added to LoadPersona
Dead JSON fallback code removed from LoadBuiltinPersona -…

rodin commented on pull request rodin/review-bot#58

2026-05-11 00:53:58 +00:00

feat: add YAML support for persona files

Addressed Review Findings (commit 10cd620)

Fixed all open review findings:

1. Dead JSON fallback code (self-review NEEDS_WORK)

Removed the dead code path in LoadBuiltinPersona that…

rodin pushed to issue-57 at rodin/review-bot

2026-05-11 00:53:47 +00:00

10cd6203d4 fix: address remaining PR #58 review findings

rodin commented on pull request rodin/review-bot#58

2026-05-11 00:36:29 +00:00

feat: add YAML support for persona files

Self-review: NEEDS_WORK

issue-57 — 2026-05-10

[fit] Dead code in LoadBuiltinPersona: The JSON fallback (data, err = embeddedPersonas.ReadFile("personas/" + jsonFile)) can never…

rodin pushed to main at rodin/model-research

2026-05-11 00:28:56 +00:00

bb50188e63 Add Finding #30: Boundary violation analysis on context README

rodin commented on pull request rodin/review-bot#58

2026-05-11 00:12:16 +00:00

feat: add YAML support for persona files

Review Findings Addressed

Commit 26f326c addresses all security and code review findings:

MAJOR (security-review-bot)

Alias cycle detection - Added seen map[*yaml.Node]struct{}…

rodin pushed to issue-57 at rodin/review-bot

2026-05-11 00:12:05 +00:00

26f326cf51 fix: add YAML alias cycle detection and multi-document rejection

rodin commented on pull request rodin/review-bot#58

2026-05-10 23:50:22 +00:00

feat: add YAML support for persona files

Addressing gpt-review-bot MINOR #2 — YAML strict field checking

Fixed in commit 4fed59a.

Enabled KnownFields(true) on the YAML decoder to reject unknown fields. This catches typos like…

rodin pushed to issue-57 at rodin/review-bot

2026-05-10 23:50:16 +00:00

4fed59ac85 yaml: enable strict field checking to catch typos

rodin commented on pull request rodin/review-bot#58

2026-05-10 23:29:59 +00:00

feat: add YAML support for persona files

Review Findings Addressed (c3e8f0f → 6035afe)

Addressed all MINOR findings from the reviews against c3e8f0f:

Code Changes (review/persona.go)

interface{} → any — Updated…

rodin pushed to issue-57 at rodin/review-bot

2026-05-10 23:29:51 +00:00

6035afeea7 fix: address MINOR review findings from c3e8f0f review

rodin pushed to main at rodin/model-research

2026-05-10 23:05:47 +00:00

8adf09b3fb Add security boundary analysis experiment (2026-05-10)

rodin commented on pull request rodin/review-bot#58

2026-05-10 22:04:49 +00:00

feat: add YAML support for persona files

Self-review: PASS

Analysis

Coherence ✅

Single clear purpose: Add YAML support for persona files
Scope is right—no unrelated changes
Story flows: extension detection → YAML…

rodin pushed to main at rodin/model-research

2026-05-10 21:50:56 +00:00

c1eb97ed6c Add finding #65: Temporal correctness analysis (new lens)

rodin commented on pull request rodin/review-bot#58

2026-05-10 21:43:47 +00:00

feat: add YAML support for persona files

Review Findings Addressed

Pushed commit c3e8f0f to address all review findings.

MAJOR Fixes

Removed false security claim — The comment said go-yaml v1.16.0+ has built-in depth…

rodin pushed to issue-57 at rodin/review-bot

2026-05-10 21:43:36 +00:00

c3e8f0f231 fix: address PR review findings