Rodin
e718cb841a
CI / test (pull_request) Successful in 17s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 25s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 44s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m40s
Reduces duplication across 7 subprocess test functions that repeated the same set of required flags verbatim. When required flags change, only baseSubprocessArgs() needs updating. Changes: - Add baseSubprocessArgs() helper (analogous to cleanEnv()) - InvalidReviewerName, InvalidTemperature, InvalidProvider, ConflictingPersonaFlags: use append(baseSubprocessArgs(), ...) - InvalidRepo: mutate a copy from baseSubprocessArgs() to set invalid --repo - InvalidPRNumber: mutate a copy from baseSubprocessArgs() to set invalid --pr - MissingLLMBaseURL, MissingAICoreCredentials, DeprecatedGiteaURLEnv: keep inline args (intentionally omit base flags); add comment explaining why - All 5 old tests migrated from deprecated --gitea-url to canonical --vcs-url All subprocess tests pass. go vet clean.