Rodin
b76270c21b
CI / test (pull_request) Successful in 12s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Failing after 17s
CI / review (gpt-5, security, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m50s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 2m43s
SAP AI Core expects anthropic_version in the JSON body, not as a header.
20 lines
1.0 KiB
Markdown
20 lines
1.0 KiB
Markdown
## Self-Review: feat/aicore-provider — 2026-05-09
|
|
|
|
### Verdict: PASS
|
|
|
|
No blocking issues found — ready for human review.
|
|
|
|
#### Notes (informational, not blocking)
|
|
|
|
**[fit]** `staticcheck` reports:
|
|
- `llm/aicore.go:237` and `llm/client.go:231`: struct literal conversion style (S1016) — minor style nit, existing in both old and new code
|
|
- `gitea/diff.go:78`: HasPrefix return ignored (SA4017) — pre-existing, not introduced by this PR
|
|
- `cmd/review-bot/main_test.go:347`: nil Context (SA1012) — pre-existing, not introduced by this PR
|
|
|
|
**[fit]** Body length validation: `aicore.go` does not include the Content-Length vs body length validation that `doRequest` has in `client.go`. This is acceptable because:
|
|
1. AI Core uses OAuth tokens which are short-lived, so truncation is less likely
|
|
2. The retry logic still applies via "read response" error pattern
|
|
3. Adding complexity to aicore.go for an edge case that hasn't manifested is premature
|
|
|
|
**[completeness]** Tests pass (go test ./...), go vet clean, no uncommitted changes.
|