rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

feat(vcs): Gitea adapter with diff-position translation (Phase 2) #90

Merged
aweiker merged 4 commits from review-bot-issue-79 into feature/github-support 2026-05-13 00:18:06 +00:00
Conversation 19 Commits 4 Files Changed 7
+2 -2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d8270262d6 - Show all commits
gitea/adapter.go
+2 -2
View File
1
 @@ -34,7 +34,7 @@ func (a *Adapter) Underlying() *Client {
func (a *Adapter) GetPullRequest(ctx context.Context, owner, repo string, number int) (*vcs.PullRequest, error) { func (a *Adapter) GetPullRequest(ctx context.Context, owner, repo string, number int) (*vcs.PullRequest, error) {
pr, err := a.client.GetPullRequest(ctx, owner, repo, number) pr, err := a.client.GetPullRequest(ctx, owner, repo, number)
if err != nil { if err != nil {
return nil, err return nil, fmt.Errorf("get pull request: %w", err)
} }
return &vcs.PullRequest{ return &vcs.PullRequest{
Number: number, Number: number,
sonnet-review-bot commented 2026-05-12 20:58:43 +00:00
Review
Copy Link
Copy Source

[MINOR] GetPullRequest does not wrap the upstream error with context. All other error returns in the adapter do wrap (e.g., PostReview wraps diff-fetch errors), but this one just returns nil, err directly. For consistency and debuggability, consider return nil, fmt.Errorf("get pull request: %w", err).

**[MINOR]** GetPullRequest does not wrap the upstream error with context. All other error returns in the adapter do wrap (e.g., PostReview wraps diff-fetch errors), but this one just returns `nil, err` directly. For consistency and debuggability, consider `return nil, fmt.Errorf("get pull request: %w", err)`.
7
 @@ -180,7 +180,7 @@ func (a *Adapter) PostReview(ctx context.Context, owner, repo string, number int
review, err := a.client.PostReview(ctx, owner, repo, number, event, req.Body, giteaComments) review, err := a.client.PostReview(ctx, owner, repo, number, event, req.Body, giteaComments)
if err != nil { if err != nil {
return nil, err return nil, fmt.Errorf("post review: %w", err)
} }
return &vcs.Review{ return &vcs.Review{
1