feat(vcs): Gitea adapter with diff-position translation (Phase 2) #90

Merged

aweiker merged 4 commits from review-bot-issue-79 into feature/github-support 2026-05-13 00:18:06 +00:00

Conversation 19 Commits 4 Files Changed 7

+1094 -38

4 Commits

Author	SHA1	Message	Date
claw	d8270262d6	Wrap errors in GetPullRequest and PostReview for consistency ... Add fmt.Errorf wrapping to the two remaining unwrapped error returns in the adapter: - GetPullRequest: 'get pull request: %w' - PostReview (final client call): 'post review: %w' This makes all error paths in the adapter consistent with the wrapping pattern used by the diff-fetch and position-translation errors. Addresses self-review findings #1 and #2 from b2eea502.	2026-05-12 14:56:55 -07:00
claw	b2eea502d0	refactor(gitea): address review feedback on PR #90 ... - position.go: Replace O(n) maxPosition scan with O(1) lookup by tracking max position during map construction. Also eliminates shadowing of the builtin max identifier (Go 1.21+). - position.go: Add comment clarifying +++ prefix ordering intent. - adapter.go: Document diff-fetch tradeoff in PostReview. - adapter_test.go: Remove extra blank line between test functions.	2026-05-12 13:57:44 -07:00
claw	0ec5093aeb	fix: address self-review findings on PR #90 ... - Remove unused error return from BuildPositionToLineMap (always nil) - Add comment explaining intentional CommitID drop in PostReview - Refactor TestAdapter_PostReview_WithComments to route by URL path - Add TestAdapter_GetFileContent_RefRouting test - Acknowledge maxPosition O(n) with code comment - Remove redundant TestAdapter_CompileTimeCheck (compile-time var _ exists) - Fix GetPullRequestFiles comment (Patch field is omitted, not 'set to empty') - Acknowledge translateEvent fallback as intentional design	2026-05-12 13:49:36 -07:00
claw	8a0eed298a	feat(vcs): Gitea adapter with diff-position translation ... Implements the Gitea adapter (gitea.Adapter) that satisfies vcs.Client. Key components: - gitea/adapter.go: Adapter struct wrapping *Client with all vcs.Client methods - gitea/position.go: BuildPositionToLineMap for diff-position → line translation - gitea/adapter_test.go: Tests for all mapping methods and event translation - gitea/position_test.go: Tests for position translation edge cases Translation details: - ReviewEvent: APPROVE → APPROVED (Gitea-native) - PostReview: fetches diff, builds position map, translates each comment - Deletion-targeted positions map to nearest non-deletion line below - All field-mapping methods tested (GetPullRequest, GetPullRequestFiles, ListReviews, GetCommitStatuses, ListContents) Also: - Added Base field to gitea.PullRequest struct - Updated conformance tests to assert Adapter (not raw Client) satisfies vcs.Client - Removed phase2 build tag from conformance tests Closes #79	2026-05-12 13:30:26 -07:00