feat(vcs): extract interfaces and types from gitea/ (Phase 1) #83

Merged

aweiker merged 4 commits from review-bot-issue-78 into feature/github-support 2026-05-12 19:14:45 +00:00

Conversation 13 Commits 4 Files Changed 3

+149

4 Commits

Author	SHA1	Message	Date
claw	cd6cd93bf0	fix(vcs): address PR #83 review findings (round 2) ... - Extract named HeadRef and UserInfo structs from anonymous structs in PullRequest and Review (comments 16615, 16616) - Change ReviewEventApprove value from "APPROVED" to "APPROVE" to represent the action, not the state; document adapter translation responsibility (comment 16621) - Add doc comment on ReviewComment.CommitID noting optionality (16531) - Move compile-time assertion from check.go (//go:build ignore) to check_test.go with a "phase2" build tag — removes gitea adapter import from the vcs package (comment 16622) - check.go misleading comment was already fixed in prior commit (16532, 16539) - Sha→SHA, typed ReviewEvent, duplicate package doc already resolved (16537, 16538, 16530)	2026-05-12 12:06:29 -07:00
claw	c889724dda	fix(vcs): address Phase 1 review findings ... - Rename PullRequest.Head.Sha → SHA (Go acronym convention) - Add typed ReviewEvent alias with exported constants - Remove duplicate package doc from types.go (kept in interfaces.go) - Fix misleading comment in check.go	2026-05-12 12:00:30 -07:00
claw	1ac51669ed	docs(vcs): add package doc to interfaces.go	2026-05-12 10:05:39 -07:00
claw	2e6f46f28d	feat(vcs): extract interfaces and types from gitea/ (Phase 1, #78) ... Add vcs/interfaces.go and vcs/types.go as the foundation for multi-platform VCS support. Interfaces are discovered from working gitea/client.go code, not invented in a vacuum. vcs/interfaces.go — role-based interfaces: - PRReader: GetPullRequest, GetPullRequestDiff, GetPullRequestFiles - FileReader: GetFileContent (path + ref), ListContents - Reviewer: PostReview (ReviewRequest), ListReviews, DeleteReview - Identity: GetAuthenticatedUser - Client: all four composed vcs/types.go — types extracted from gitea/: - PullRequest, ChangedFile, ContentEntry, Review (identical to gitea/) - ReviewComment: uses GitHub diff-position convention (Position int, CommitID string) instead of Gitea's NewPosition int64 - ReviewRequest: new type wrapping Body, Event, Comments vcs/check.go (//go:build ignore) — documents the gaps gitea.Client must bridge in Phase 2: 1. PostReview signature mismatch (event+body+[]ReviewComment vs ReviewRequest) 2. GetFileContent missing ref parameter 3. ReviewComment type mismatch (NewPosition vs Position/CommitID) No behavior changes. All existing tests pass.	2026-05-12 10:04:57 -07:00