rodin/review-bot

feat: always post fresh review, supersede old with collapsed body #38

Merged

rodin merged 3 commits from feat/34-always-post-fresh into main

2026-05-02 18:36:43 +00:00

Author	SHA1	Message	Date
Rodin	f6baa41b2c	fix: remove findOwnReviewStrict, use findOwnReview directly CI / test (pull_request) Successful in 14s Details CI / review (gpt-4.1, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 23s Details CI / review (gpt-5, security, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 42s Details CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 1m31s Details The strict authorship check compared reviewer-name to User.Login which could mismatch. The sentinel is already role-specific (e.g. <!-- review-bot:sonnet -->) and Gitea's API blocks editing others' comments (403). Defense-in-depth via login comparison is unnecessary complexity that introduced a bug. Removed.	2026-05-02 11:33:57 -07:00
Rodin	ecbae332f4	fix: address review findings CI / test (pull_request) Successful in 14s Details CI / review (gpt-4.1, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 23s Details CI / review (gpt-5, security, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m17s Details CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 1m22s Details - findOwnReview: skip superseded reviews, pick highest ID (most recent) - findOwnReviewStrict: verify authorship before superseding (defense-in-depth) - buildSupersededBody: handle empty commitSHA gracefully - Tests: add cases for superseded skip, highest-ID selection	2026-05-02 11:30:34 -07:00
Rodin	fdd75699d9	feat: always post fresh review, supersede old with collapsed body CI / test (pull_request) Successful in 14s Details CI / review (gpt-4.1, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 23s Details CI / review (gpt-5, security, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m2s Details CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 1m25s Details Closes #34 - Remove reviewUnchanged() skip logic — every push gets a fresh review - Remove edit-in-place (PATCH same body) — always POST new - Supersede old review: PATCH with struck-through banner + collapsed original body in <details> for historical reference - Add commit footer to every review: 'Evaluated against <sha>' - Remove --update-existing flag (no longer needed) - Add CommitID field to Review struct - Add TestBuildSupersededBody tests	2026-05-02 11:26:06 -07:00