rodin/review-bot

fix: path-escape file paths and eliminate url package shadowing #17

Merged

rodin merged 4 commits from fix/url-escaping-and-shadow into main

2026-05-01 21:55:02 +00:00

Author	SHA1	Message	Date
Rodin	aade891129	docs: add package-level documentation CI / test (pull_request) Successful in 14s Details CI / review (gpt-5-mini, gpt, GPT_REVIEW_TOKEN) (pull_request) Failing after 1m6s Details CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Failing after 55s Details Per go-patterns/package-design.md, every package needs a doc comment. Added to gitea, llm, and review packages.	2026-05-01 14:54:58 -07:00
Rodin	7b42de67ca	fix: handle empty path in ListContents (root listing) CI / test (pull_request) Successful in 14s Details CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 1m4s Details CI / review (gpt-5-mini, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m8s Details Empty path now yields /contents instead of /contents/ (trailing slash). Added doc comment noting empty path = repo root.	2026-05-01 14:46:40 -07:00
Rodin	dd2661fe14	fix: address all review findings from PR #17 CI / test (pull_request) Successful in 13s Details CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 52s Details CI / review (gpt-5-mini, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m12s Details - Rename all remaining url locals to reqURL (consistency) - Use http.MethodGet/http.MethodPost constants - Document escapePath: relative paths only, double-encoding expected - Add TestEscapePath with 7 edge cases (empty, spaces, #, deep, encoded)	2026-05-01 14:40:19 -07:00
Rodin	98a4772f30	fix: path-escape file paths and eliminate url package shadowing CI / test (pull_request) Successful in 14s Details CI / review (gpt-5-mini, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m48s Details CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 55s Details - Add escapePath() helper: escapes each path segment individually (preserves slashes as separators, escapes spaces/#/? etc) - Apply to GetFileContent, GetFileContentRef, ListContents - Rename doGet parameter from url to reqURL (avoids shadowing net/url) - Rename local variables in GetFileContent/ListContents for consistency Addresses remaining findings from PR #16 review.	2026-05-01 14:33:18 -07:00