fix(#120): detect VCS host for releases API and derive action-repo #122
Closed
rodin
wants to merge 2 commits from
issue-120 into feature/github-support
pull from: issue-120
merge into: rodin:feature/github-support
rodin:main
rodin:ci/cleanup
rodin:ci-selfreview-gate
rodin:issue-150
rodin:issue-157
rodin:issue-141
rodin:issue-154
rodin:review-bot-dev-loop
rodin:issue-143
rodin:issue-146
rodin:pr-153
rodin:review-bot-issue-130-work
rodin:issue-148
rodin:issue-139
rodin:issue-137
rodin:review-bot-fixes
rodin:review-bot-issue-133
rodin:review-bot-issue-130
rodin:issue-130
rodin:github-support
rodin:issue-123-work
rodin:issue-123
rodin:review-bot-issue-120
rodin:fix/125-readme-cli-example
rodin:issue-125
rodin:issue-124
rodin:feature/github-support
rodin:review-bot-issue-116
rodin:review-bot-issue-115
rodin:review-bot-issue-114
rodin:review-bot-issue-96
rodin:review-bot-issue-107
rodin:review-bot-issue-82
rodin:review-bot-issue-95
rodin:review-bot-issue-92
rodin:review-bot-issue-94
rodin:review-bot-issue-81
rodin:review-bot-issue-91
rodin:review-bot-issue-97
rodin:issue-80-c-file-reader
rodin:issue-80-b-pr-reader
rodin:issue-80-a-client
rodin:review-bot-issue-80
rodin:review-bot-issue-87
rodin:review-bot-issue-79
rodin:review-bot-issue-84
rodin:review-bot-issue-78
rodin:issue-73
rodin:issue-70
rodin:issue-68
rodin:issue-66
rodin:issue-64
rodin:issue-60-remote-personas
rodin:issue-60
rodin:issue-57
rodin:allow-deps
rodin:feat/aicore-provider-v2
rodin:issue-51
rodin:ci/pr-ready-gate
rodin:fix/stale-commit-check
rodin:feat/aicore-provider
rodin:fix/response-body-truncation
rodin:fix/json-repair
rodin:fix/sonnet-reviewer
rodin:fix/consistent-path-escape
rodin:feat/inline-review-comments
rodin:feat/6-update-existing-review
rodin:fix/19-context-overflow
rodin:feat/18-anthropic-api
rodin:fix/url-escaping-and-shadow
rodin:fix/quick-wins
rodin:fix/context-and-encapsulation
rodin:docs/code-review-report
rodin:ci/release-workflow
2 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
db13078196 |
chore: use dry-run in review.yml (GHE has no releases yet, validate infra)
PR Ready Gate / clear-labels (pull_request) Successful in 1s
CI / test (pull_request) Successful in 20s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 29s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m2s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m31s
The self-test workflow on github.concur.com runs the action with: - gitea-url=https://gitea.weiker.me (binary download source) - dry-run=true (avoids PR# mismatch between GHE and Gitea) This validates: - Binary download and checksum verification works from a GitHub runner - GITHUB_SERVER_URL/GITHUB_REPOSITORY env vars are correctly passed - AiCore provider authenticates and LLM call succeeds When strat/review-bot has its own releases, remove gitea-url override and dry-run. |
||
|
|
3ac5e5dcca |
fix(#120): detect VCS host for releases API and derive action-repo
CI / test (pull_request) Successful in 20s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 29s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m40s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 2m3s
Both composite actions hardcoded: - Gitea's /api/v1/ releases endpoint path - 'rodin/review-bot' as the action source repo - .gitea version used GITEA_URL/GITEA_REPO env vars instead of GITHUB_SERVER_URL/GITHUB_REPOSITORY Fix: - Add 'action-repo' input (default: empty) to allow explicit override - Auto-detect VCS host from server_url: URLs containing 'gitea' use /api/v1/ (Gitea format), all others use /api/v3/ (GitHub format) - Set smart default action-repo: 'rodin/review-bot' on Gitea, 'strat/review-bot' on GitHub - Pass server-url and action-repo as step outputs to avoid re-computing - Fix .gitea action's 'Run review' env to use GITHUB_SERVER_URL and GITHUB_REPOSITORY (matching .github version and review-bot binary env var expectations) - Add .github/workflows/review.yml for self-testing on github.concur.com Backward compatible: existing Gitea callers using default inputs continue to resolve rodin/review-bot via /api/v1/ unchanged. Closes #120 |