rodin/review-bot

fix(github): consolidate review.go and identity.go into reviews.go (#116) #119

Merged

aweiker merged 4 commits from review-bot-issue-116 into feature/github-support

2026-05-14 01:49:57 +00:00

Author	SHA1	Message	Date
claw	437e318240	nit: clarify truncation detection comment in ListReviews PR Ready Gate / clear-labels (pull_request) Successful in 2s Details CI / test (pull_request) Successful in 19s Details CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 39s Details CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 39s Details CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 59s Details Expand the inline comment at the page==maxPages check to more explicitly explain why a full final page implies truncation.	2026-05-13 18:01:57 -07:00
claw	2e2fcbabfc	style: fix import ordering and restore nil-body comment PR Ready Gate / clear-labels (pull_request) Successful in 2s Details CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 38s Details CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 40s Details CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 56s Details CI / test (pull_request) Successful in 19s Details - Reorder stdlib imports in review_test.go to alphabetical (goimports convention) - Restore explanatory comment for nil body in DeleteReview Addresses review comments #20533, #20534 on PR #119	2026-05-13 17:53:20 -07:00
claw	8e26c26f5f	fix(github): add pagination tests and fix truncation warning logic PR Ready Gate / clear-labels (pull_request) Successful in 2s Details CI / test (pull_request) Successful in 20s Details CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 24s Details CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 56s Details CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m31s Details F1: Add comprehensive pagination tests for ListReviews covering: - Multi-page behaviour (2 full + 1 partial page) - Exact-multiple-of-pageSize (extra empty-page round-trip) - maxReviewPages cutoff (cap hit, results still returned) - Empty first page (PR with no reviews) F2: Fix truncation warning logic by moving it outside the loop with a 'truncated' flag. Previously, the warning fired inline at page==maxPages which could miss the case where the short-page break fires first on the cap page. Now it only fires when the loop exits because the cap was reached and the last page was full (indicating more data likely exists). Also adds SetReviewPagination to Client for test-time override of page size and max pages, following the existing SetRetryBackoff pattern.	2026-05-13 17:22:51 -07:00
claw	22b3ce8fef	fix(github): consolidate review.go and identity.go into reviews.go (#116 ) Remove github/review.go and github/identity.go, replacing them with a consolidated github/reviews.go that: - Uses doJSONRequest for PostReview and DismissReview (cleaner than manual marshal + doRequestWithBody) - Adds paginated ListReviews with per_page=100 and max 100 pages - Consolidates GetAuthenticatedUser and userResponse type (previously duplicated in identity.go) - Preserves all sentinel errors (ErrCannotDeleteSubmittedReview, ErrConflictingCommitIDs), state translation, commit ID validation, and SupersedeReviews This prevents the redeclaration errors that occur when both review.go and reviews.go exist in the same package, as described in issue #116. Closes #116	2026-05-13 17:21:24 -07:00