feat(github): implement PRReader interface #102

Merged

aweiker merged 5 commits from issue-80-b-pr-reader into feature/github-support 2026-05-13 05:30:37 +00:00

Conversation 20 Commits 5 Files Changed 5

+1104

5 Commits

Author	SHA1	Message	Date
claw	55366b3431	fix: address review feedback on PRReader implementation ... - Add maxFileContentSize (10 MB) limit to decodeBase64Content to prevent resource exhaustion from oversized file content (security MINOR) - Fix reversed NewClient arg order in TestGetFileContentAtRef_DotSegmentError (GPT MINOR + Sonnet NIT) - Remove 'waiting' from mapCheckRunStatus conclusion cases since it is a status value not a conclusion, update comment (GPT NIT) - Add TestDecodeBase64Content_SizeLimit test	2026-05-12 22:17:32 -07:00
claw	3cd5ae594e	fix(github): escapePath returns error on dot-segments, fix Description semantics ... - escapePath now returns an error when paths contain dot-segments (".", "..") instead of silently rewriting them. This prevents subtle API misses where callers pass "foo/../bar" expecting to hit "bar" but the old code produced "foo/bar". - Uses path.Clean for canonical form after validation. - CommitStatus.Description for check runs is now empty string instead of the raw conclusion enum. The conclusion is already captured in the Status field via mapCheckRunStatus; storing it again in Description was semantically inconsistent with commit statuses where Description carries a human-readable narrative. - Removed unused derefString helper. - Added tests for escapePath valid paths, dot-segment rejection, and GetFileContentAtRef dot-segment error propagation.	2026-05-12 22:03:52 -07:00
clawandaweiker	eaccc96073	fix: address review feedback on PR #102 ... - Separate maxPages into maxFilesPages and maxCheckRunPages constants for clarity (sonnet MINOR #1) - Add parallel to CheckRunConclusions subtests (sonnet MINOR #2) - Add TestGetCommitStatuses_CheckRunsErrorAfterStatusesSucceed test covering check-runs 500 after statuses succeed (sonnet MINOR #2) - Expand mapCheckRunStatus doc comment with full mapping rules including cancelled/skipped/neutral rationale and unknown value behavior (sonnet MINOR #3, gpt MINOR #1) - Expand GetPullRequest doc comment to mention error types returned (sonnet NIT #4) - Add inline comment on Description field clarifying it holds raw conclusion value (gpt NIT #3)	2026-05-13 04:47:15 +00:00
clawandaweiker	289b400bfd	fix(github): add GetFileContentAtRef and fix conformance test ... - Implement GetFileContentAtRef on *Client to satisfy vcs.PRReader interface - Add escapePath and decodeBase64Content helpers - Fix conformance_test.go to properly import and qualify github.Client (was using unqualified Client in package github_test) Fixes CI failure: the PRReader interface requires GetFileContentAtRef but it was missing from this PR (only present in the file-reader PR).	2026-05-13 04:47:15 +00:00
aweikerandaweiker	d0b7f09772	feat(github): implement PRReader interface (#80) ... Implement PRReader conformance on the GitHub client: GetPullRequest, GetPullRequestDiff, GetPullRequestFiles (paginated, populates Patch), GetCommitStatuses (merges commit statuses + check runs). Adds compile-time PRReader conformance check. Requires PR A. Part 2 of 3 for #80.	2026-05-13 04:47:15 +00:00