feat(github): implement GitHub API client foundation #101

Merged

aweiker merged 3 commits from issue-80-a-client into feature/github-support 2026-05-13 04:46:46 +00:00

Conversation 14 Commits 3 Files Changed 3

+939

3 Commits

Author	SHA1	Message	Date
claw	61819ac3e3	fix(github): address review findings - remove panic, validate at config time ... - MAJOR #1: Replace panic in doRequest with safe default fallback. Validation now happens in SetRetryBackoff (returns error on invalid length). doRequest gracefully falls back to default backoff if the configured slice is somehow invalid. - MINOR #2: SetRetryBackoff validates slice length at configuration time, making the coupling between maxRetryAttempts and backoff explicit and catching mismatches early with a clear error. - MINOR #4: Reword oversized response error to remove '(truncated)' which implied truncated data was returned when actually only an error is returned. - MINOR #5: Functional options kept as-is - idiomatic Go pattern that allows future growth without breaking the API.	2026-05-12 21:31:45 -07:00
claw	3d1260d3b2	fix(github): clarify response ownership and validate backoff length ... Address review feedback on PR #101: 1. Capture resp.StatusCode and Retry-After header *before* passing resp to handleResponse, making ownership transfer explicit. Previously the caller read resp.StatusCode after handleResponse had closed the body — correct but fragile coupling. 2. Add panic guard ensuring backoff slice length equals maxAttempts-1. Previously the relationship was implicit and could silently break if maxAttempts were changed without updating the default backoff.	2026-05-12 21:26:39 -07:00
aweiker	0e7e12a99c	feat(github): implement GitHub API client foundation (#80) ... Add GitHub API client with configurable base URL and GHE support, HTTP helpers with 429 retry and Retry-After handling. Also adds Patch field to vcs.ChangedFile. Part 1 of 3 for #80.	2026-05-13 04:11:53 +00:00