nit(#154): add t.Fatal guard if baseSubprocessArgs flag not found

Address sonnet NIT: if --repo or --pr is ever removed from
baseSubprocessArgs(), the mutation loop silently no-ops and the test
becomes meaningless. Adding a found guard and t.Fatal makes the
regression immediately visible.

CYCLE_STATUS_2026-05-15-1442.md

@@ -0,0 +1,38 @@
+# Dev-Loop Cycle Status — 2026-05-15 14:42 UTC
+
+**Cron ID:** 5342ac81-4bbc-4e4c-a123-347a7788d50c  
+**Cycle:** review-bot-dev-loop (4-hour schedule)  
+**Status:** ✅ **STEADY STATE** — All systems nominal, repo healthy
+
+## Health Check Summary
+
+| Check | Status | Details |
+|-------|--------|---------|
+| Main branch | ✅ Current | HEAD at 8ab45be (synced) |
+| Working tree | ✅ Clean | No uncommitted changes |
+| Test suite | ✅ All pass | 100% pass rate (go test ./...) |
+| Code coverage | ✅ 76.7% | Above baseline target |
+| Open issues | ✅ None | No assigned work |
+| Open PRs | ✅ None | All merged |
+| Remote sync | ✅ On-time | Up-to-date with origin/main |
+
+## Actions This Cycle
+
+- ✅ Fetched origin/main — up-to-date
+- ✅ Ran full test suite — all pass
+- ✅ Calculated code coverage — 76.7%
+- ✅ Checked for new issues/PRs — none found
+- ✅ Verified working tree clean
+
+## Backlog Opportunities
+
+1. **Integration tests** — cmd/review-bot coverage (53.3% → target 80%)
+2. **Performance profiling** — doc-map filtering optimization
+3. **Documentation** — Composite action examples
+
+## Recommendation
+
+**No new assignments.** Repo ready for next feature work. Standing by.
+
+---
+Generated: 2026-05-15 14:42 UTC | Cron: review-bot-dev-loop

DEV_LOOP_SESSION_2026-05-15-1428.md

@@ -1,53 +0,0 @@
-# Dev-Loop Session — 2026-05-15 14:28 UTC
-
-**Cron ID:** 5342ac81-4bbc-4e4c-a123-347a7788d50c  
-**Session:** review-bot-dev-loop  
-**Objective:** Identify high-value improvement opportunities in steady-state project
-
-## Current State
-
-- **Project Status:** ✅ Steady state, all tests passing
-- **Code Coverage:** 76.7% overall, 53.3% for cmd/review-bot
-- **Recent Work:** v0.4.0 released, 4 PRs merged
-- **Last Commit:** 6fa3cb9 — cycle status checkpoint
-- **Working Tree:** Clean, no uncommitted changes
-
-## Analysis
-
-### High-Value Opportunities
-
-1. **Unit Test Coverage Gaps (cmd/review-bot)**
-   - Main function: 31.7% coverage (target for improvement)
-   - Subprocess testing infrastructure exists (`TestMainSubprocess_*` pattern)
-   - Goal: Reach 80% coverage from 53.3%
-   - Impact: Better regression protection, easier refactoring
-
-2. **Integration Test Framework**
-   - Existing: `integration_test.go` with full review flow tested
-   - Opportunity: Add edge case coverage (network timeouts, malformed inputs, rate limiting)
-   - Tools: Already uses subprocess pattern from validation tests
-
-3. **Performance Profiling**
-   - doc-map filtering currently unoptimized
-   - No benchmarks in place for path-scoping logic
-   - Opportunity: Add pprof benchmarks, document baseline metrics
-
-4. **Documentation Gaps**
-   - Composite action examples in README (incomplete)
-   - Multi-reviewer setup: partially documented
-   - Specialized review types: needs examples
-
-## Recommendation
-
-**Unit test improvements** for cmd/review-bot are the highest-value work:
-- Lower risk than new features
-- Builds on existing subprocess testing infrastructure
-- Delivers immediate coverage gains
-- Sets foundation for future refactoring
-
-## Status: STEADY STATE — NO NEW ASSIGNMENTS
-
-Repo is healthy and ready for next feature work. Standing by for Aaron's direction.
-
----
-Generated: 2026-05-15 14:28 UTC | Cron: review-bot-dev-loop

cmd/review-bot/main_test.go

@@ -903,12 +903,17 @@ func TestMainSubprocess_InvalidRepo(t *testing.T) {
 		flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ExitOnError)
 		args := baseSubprocessArgs()
 		// Replace the canonical --repo value with an invalid one.
+		found := false
 		for i, a := range args {
 			if a == "--repo" && i+1 < len(args) {
 				args[i+1] = "invalidrepo"
+				found = true
 				break
 			}
 		}
+		if !found {
+			t.Fatal("baseSubprocessArgs() does not contain --repo; test is broken")
+		}
 		os.Args = args
 		main()
 		return
@@ -930,12 +935,17 @@ func TestMainSubprocess_InvalidPRNumber(t *testing.T) {
 		flag.CommandLine = flag.NewFlagSet(os.Args[0], flag.ExitOnError)
 		args := baseSubprocessArgs()
 		// Replace the canonical --pr value with a non-numeric string.
+		found := false
 		for i, a := range args {
 			if a == "--pr" && i+1 < len(args) {
 				args[i+1] = "notanumber"
+				found = true
 				break
 			}
 		}
+		if !found {
+			t.Fatal("baseSubprocessArgs() does not contain --pr; test is broken")
+		}
 		os.Args = args
 		main()
 		return